Issue 9358030: PPAPI: Dial back the PostMessage threading test and re-enable on Win

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9358030: PPAPI: Dial back the PostMessage threading test and re-enable on Win (Closed)

Created:
8 years, 10 months ago by dmichael (off chromium)

Modified:
8 years, 10 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

PPAPI: Dial back the PostMessage threading test and re-enable on Win The test runs fine for me on a 32-bit Win XP machine, so I'm speculating it was just timing out on the bots. Timeout was probably especially likely when the PostMessage tests were all run together. BUG=95557 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121255

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	chrome/test/ui/ppapi_uitest.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
	M	ppapi/tests/test_post_message.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dmichael (off chromium)

Note since there are no XP trybots, I'm going to probably to land this manually ...

8 years, 10 months ago (2012-02-08 18:25:33 UTC) #1

lgtm

Expand Messages | Collapse Messages