Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2814)

Unified Diff: base/android/scoped_java_ref.cc

Issue 9358028: Upstream Android JNI code, allowing us to use more ScopedJava references. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased and added a TODO Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/android/scoped_java_ref.h ('k') | base/android/scoped_java_ref_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/scoped_java_ref.cc
diff --git a/base/android/scoped_java_ref.cc b/base/android/scoped_java_ref.cc
index da932f8ddd0753571ffbcaf54e9e90b614614441..a7e073a4989f4ca813f29f35fcf13ada4de8eb18 100644
--- a/base/android/scoped_java_ref.cc
+++ b/base/android/scoped_java_ref.cc
@@ -4,6 +4,8 @@
#include "base/android/scoped_java_ref.h"
+#include "base/logging.h"
+
namespace base {
namespace android {
@@ -12,7 +14,10 @@ JavaRef<jobject>::JavaRef() : env_(NULL), obj_(NULL) {}
JavaRef<jobject>::JavaRef(JNIEnv* env, jobject obj)
: env_(env),
obj_(obj) {
- DCHECK_EQ(JNILocalRefType, env->GetObjectRefType(obj));
+ if (obj) {
+ DCHECK(env);
+ DCHECK_EQ(JNILocalRefType, env->GetObjectRefType(obj));
+ }
}
JavaRef<jobject>::~JavaRef() {
@@ -36,6 +41,20 @@ void JavaRef<jobject>::SetNewGlobalRef(JNIEnv* env, jobject obj) {
obj_ = obj;
}
+void JavaRef<jobject>::ResetLocalRef() {
+ if (obj_)
+ env_->DeleteLocalRef(obj_);
+ env_ = NULL;
+ obj_ = NULL;
+}
+
+void JavaRef<jobject>::ResetGlobalRef() {
+ if (obj_)
+ env_->DeleteGlobalRef(obj_);
+ env_ = NULL;
+ obj_ = NULL;
+}
+
jobject JavaRef<jobject>::ReleaseInternal() {
jobject obj = obj_;
env_ = NULL;
« no previous file with comments | « base/android/scoped_java_ref.h ('k') | base/android/scoped_java_ref_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698