Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3072)

Unified Diff: base/test/test_stub_android.cc

Issue 9358028: Upstream Android JNI code, allowing us to use more ScopedJava references. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/android/jni_string.h ('K') | « base/base.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/test_stub_android.cc
diff --git a/base/test/test_stub_android.cc b/base/test/test_stub_android.cc
index 82e645e7a52f7b292bbd923e471a3719bd84ece1..b236feef158586439bc983d7e1b4ba29a3bbef87 100644
--- a/base/test/test_stub_android.cc
+++ b/base/test/test_stub_android.cc
@@ -179,17 +179,8 @@ void InitAndroidTestStub() {
MessageLoop::InitMessagePumpForUIFactory(&CreateMessagePumpForUIStub);
}
-// TODO(michaelbai): The below DetachFromVM was added because we excluded the
-// jni_android.{h|cc} which require JNI to compile. Remove them when those 2
-// files added.
namespace base {
-namespace android {
-
-void DetachFromVM() {}
-
-} // namespace android
-
// TODO(michaelbai): The below MessagePumpForUI were added because we excluded
// message_pump_android.{h|cc} which require JNI to compile. Remove them when
// those 2 files added.
« base/android/jni_string.h ('K') | « base/base.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698