Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: base/android/scoped_java_ref.cc

Issue 9358028: Upstream Android JNI code, allowing us to use more ScopedJava references. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased and added a TODO Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/android/scoped_java_ref.h ('k') | base/android/scoped_java_ref_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/android/scoped_java_ref.h" 5 #include "base/android/scoped_java_ref.h"
6 6
7 #include "base/logging.h"
8
7 namespace base { 9 namespace base {
8 namespace android { 10 namespace android {
9 11
10 JavaRef<jobject>::JavaRef() : env_(NULL), obj_(NULL) {} 12 JavaRef<jobject>::JavaRef() : env_(NULL), obj_(NULL) {}
11 13
12 JavaRef<jobject>::JavaRef(JNIEnv* env, jobject obj) 14 JavaRef<jobject>::JavaRef(JNIEnv* env, jobject obj)
13 : env_(env), 15 : env_(env),
14 obj_(obj) { 16 obj_(obj) {
15 DCHECK_EQ(JNILocalRefType, env->GetObjectRefType(obj)); 17 if (obj) {
18 DCHECK(env);
19 DCHECK_EQ(JNILocalRefType, env->GetObjectRefType(obj));
20 }
16 } 21 }
17 22
18 JavaRef<jobject>::~JavaRef() { 23 JavaRef<jobject>::~JavaRef() {
19 } 24 }
20 25
21 void JavaRef<jobject>::SetNewLocalRef(JNIEnv* env, jobject obj) { 26 void JavaRef<jobject>::SetNewLocalRef(JNIEnv* env, jobject obj) {
22 if (obj) 27 if (obj)
23 obj = env->NewLocalRef(obj); 28 obj = env->NewLocalRef(obj);
24 if (obj_) 29 if (obj_)
25 env_->DeleteLocalRef(obj_); 30 env_->DeleteLocalRef(obj_);
26 env_ = env; 31 env_ = env;
27 obj_ = obj; 32 obj_ = obj;
28 } 33 }
29 34
30 void JavaRef<jobject>::SetNewGlobalRef(JNIEnv* env, jobject obj) { 35 void JavaRef<jobject>::SetNewGlobalRef(JNIEnv* env, jobject obj) {
31 if (obj) 36 if (obj)
32 obj = env->NewGlobalRef(obj); 37 obj = env->NewGlobalRef(obj);
33 if (obj_) 38 if (obj_)
34 env_->DeleteGlobalRef(obj_); 39 env_->DeleteGlobalRef(obj_);
35 env_ = env; 40 env_ = env;
36 obj_ = obj; 41 obj_ = obj;
37 } 42 }
38 43
44 void JavaRef<jobject>::ResetLocalRef() {
45 if (obj_)
46 env_->DeleteLocalRef(obj_);
47 env_ = NULL;
48 obj_ = NULL;
49 }
50
51 void JavaRef<jobject>::ResetGlobalRef() {
52 if (obj_)
53 env_->DeleteGlobalRef(obj_);
54 env_ = NULL;
55 obj_ = NULL;
56 }
57
39 jobject JavaRef<jobject>::ReleaseInternal() { 58 jobject JavaRef<jobject>::ReleaseInternal() {
40 jobject obj = obj_; 59 jobject obj = obj_;
41 env_ = NULL; 60 env_ = NULL;
42 obj_ = NULL; 61 obj_ = NULL;
43 return obj; 62 return obj;
44 } 63 }
45 64
46 } // namespace android 65 } // namespace android
47 } // namespace base 66 } // namespace base
OLDNEW
« no previous file with comments | « base/android/scoped_java_ref.h ('k') | base/android/scoped_java_ref_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698