Upstream Android JNI code, allowing us to use more ScopedJava references.

base/android/jni_string.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_ANDROID_JNI_STRING_H_
 #define BASE_ANDROID_JNI_STRING_H_
 
 #include <jni.h>
 #include <string>
 
+#include "base/android/scoped_java_ref.h"
 #include "base/string16.h"
 #include "base/string_piece.h"
 
 namespace base {
 namespace android {
 
 // Convert a Java string to UTF8. Returns a std string.
 std::string ConvertJavaStringToUTF8(JNIEnv* env, jstring str);
+std::string ConvertJavaStringToUTF8(const JavaRef<jstring>& str);
 
 // Convert a std string to Java string.
-jstring ConvertUTF8ToJavaString(JNIEnv* env, const base::StringPiece& str);
+ScopedJavaLocalRef<jstring> ConvertUTF8ToJavaString(

[Steve Block, 2012/02/08 18:41:55]

I think this will break JavaBoundObject. Is the Java Bridge currently compiled
in an upstream Android build? If not, it would be good to fix that ASAP, as it's
not built on any other upstream platforms.

[Jay Civelli, 2012/02/08 18:49:56]

In the JavaBoundObject we release the actual scoped pointer so the behavior
should be the same as it was before.

[Steve Block, 2012/02/08 19:02:43]

I just meant that it will cause a build break. JavaBoundObject uses 'jobject foo
= ConvertUTF8ToJavaString(...);'

[Peter Beverloo, 2012/02/09 15:25:29]

There are several other files which have to be updated, I'll do that in follow
up CLs. We don't build the content/ folder at this time yet.

+    JNIEnv* env, const base::StringPiece& str);
 
 // Convert a Java string to UTF16. Returns a string16.
 string16 ConvertJavaStringToUTF16(JNIEnv* env, jstring str);
+string16 ConvertJavaStringToUTF16(const JavaRef<jstring>& str);
 
 // Convert a string16 to a Java string.
-jstring ConvertUTF16ToJavaString(JNIEnv* env, const string16& str);
+ScopedJavaLocalRef<jstring> ConvertUTF16ToJavaString(
+    JNIEnv* env, const string16& str);
 
 }  // namespace android
 }  // namespace base
 
 #endif  // BASE_ANDROID_JNI_STRING_H_