src/builtins.cc - Issue 9358018: Fix elements transition bug related to array.concat.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins.cc

Issue 9358018: Fix elements transition bug related to array.concat. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: added test Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins.cc

diff --git a/src/builtins.cc b/src/builtins.cc

index bcb1198e5795dde2ba6a3383567d30e1304e5fba..1badca7bc574f4c76225c02784ba0ef0cf6f8915 100644

--- a/src/builtins.cc

+++ b/src/builtins.cc

@@ -978,7 +978,7 @@ BUILTIN(ArrayConcat) {

return CallJsBuiltin(isolate, "ArrayConcat", args);

}

- if (!JSArray::cast(arg)->HasFastElements()) {

+ if (!JSArray::cast(arg)->HasFastSmiOnlyElements()) {

elements_kind = FAST_ELEMENTS;

}

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-smi-only-concat.js » ('j') | no next file with comments »