Issue 9356002: Remove unnecessary elements type check when allocating array in runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9356002: Remove unnecessary elements type check when allocating array in runtime. (Closed)

Created:
8 years, 10 months ago by Yang

Modified:
8 years, 10 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove unnecessary elements type check when allocating array in runtime. BUG= TEST=--smi-only-arrays should be perf-neutral to allocating big arrays in a tight loop. Committed: https://code.google.com/p/v8/source/detail?r=10711

Patch Set 1 #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	src/builtins.cc	View		1 chunk	+4 lines, -4 lines	1 comment	Download
	M	src/heap.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

danno

8 years, 10 months ago (2012-02-15 12:08:10 UTC) #2

LGTM with comment

http://codereview.chromium.org/9356002/diff/1/src/builtins.cc
File src/builtins.cc (right):

http://codereview.chromium.org/9356002/diff/1/src/builtins.cc#newcode225
src/builtins.cc:225: array->set_elements(FixedArray::cast(fixed_array));
Add a comment why SetContent isn't a good idea here.

Expand Messages | Collapse Messages