Prevent future app banners when app is added to the homescreen via menu

Prevent future app banners when app is added to the homescreen via menu

BUG=457393
Committed: https://crrev.com/840ae9096069cd21c3193081093496ad68f27e9e
Cr-Commit-Position: refs/heads/master@{#316652}

[benwells, 2015-02-17 08:02:49]

benwells@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[gone, 2015-02-17 17:58:43]

LGTM when the call is moved.

https://chromiumcodereview.appspot.com/935533002/diff/1/chrome/browser/androi...
File chrome/browser/android/shortcut_helper.cc (right):

https://chromiumcodereview.appspot.com/935533002/diff/1/chrome/browser/androi...
chrome/browser/android/shortcut_helper.cc:235: RecordAddToHomescreen();
The common point in the pathway for these is to go through
AddShortcutInBackgroundWithSkBitmap().  Just put a RecordAddToHomescreen there
and you should be good.

[benwells, 2015-02-17 19:49:53]

https://codereview.chromium.org/935533002/diff/1/chrome/browser/android/short...
File chrome/browser/android/shortcut_helper.cc (right):

https://codereview.chromium.org/935533002/diff/1/chrome/browser/android/short...
chrome/browser/android/shortcut_helper.cc:235: RecordAddToHomescreen();
On 2015/02/17 17:58:43, dfalcantara wrote:
> The common point in the pathway for these is to go through
> AddShortcutInBackgroundWithSkBitmap().  Just put a RecordAddToHomescreen there
> and you should be good.

That's true but it is on the wrong thread. See
https://code.google.com/p/chromium/codesearch#chromium/src/components/content....

I could post a task from that common chokepoint back to the UI thread but that
felt a bit heavy.

[gone, 2015-02-17 19:52:08]

LGTM as is.

https://codereview.chromium.org/935533002/diff/1/chrome/browser/android/short...
File chrome/browser/android/shortcut_helper.cc (right):

https://codereview.chromium.org/935533002/diff/1/chrome/browser/android/short...
chrome/browser/android/shortcut_helper.cc:235: RecordAddToHomescreen();
On 2015/02/17 19:49:53, benwells wrote:
> On 2015/02/17 17:58:43, dfalcantara wrote:
> > The common point in the pathway for these is to go through
> > AddShortcutInBackgroundWithSkBitmap().  Just put a RecordAddToHomescreen
there
> > and you should be good.
> 
> That's true but it is on the wrong thread. See
>
https://code.google.com/p/chromium/codesearch#chromium/src/components/content....
> 
> I could post a task from that common chokepoint back to the UI thread but that
> felt a bit heavy.

Hrm, fair point.

[benwells, 2015-02-17 20:11:55]

The CQ bit was checked by benwells@chromium.org

[benwells, 2015-02-17 20:11:58]

The CQ bit was unchecked by benwells@chromium.org

[benwells, 2015-02-17 20:12:27]

benwells@chromium.org changed reviewers:
+ tedchoc@chromium.org

[benwells, 2015-02-17 20:12:27]

+tedchoc for owners

[Ted C, 2015-02-17 20:48:44]

lgtm

[benwells, 2015-02-17 20:49:00]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2015-02-17 20:51:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/935533002/1

[commit-bot: I haz the power, 2015-02-17 21:13:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-17 21:14:35]

Patchset 1 (id:??) landed as
https://crrev.com/840ae9096069cd21c3193081093496ad68f27e9e
Cr-Commit-Position: refs/heads/master@{#316652}