Plumb through cache_identity from manifest for first sketch of pnacl cache.

Plumb through cache_identity from manifest for first sketch of pnacl cache.  Probe cache for lookups.


BUG= http://code.google.com/p/nativeclient/issues/detail?id=1714
TEST= run_pnacl_example_browser_test

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123178

[jvoung - send to chromium..., 2012-02-21 01:53:21]

will be out tomorrow (mini vacation), but if you wanted to patch this in and
work on it feel free. I think the manifest plumbing is in, but the cache lookup
is not yet in...

[sehr (please use chromium), 2012-02-22 19:30:37]

One bug (I think).

http://codereview.chromium.org/9355051/diff/2001/ppapi/native_client/src/trus...
File ppapi/native_client/src/trusted/plugin/json_manifest.cc (right):

http://codereview.chromium.org/9355051/diff/2001/ppapi/native_client/src/trus...
ppapi/native_client/src/trusted/plugin/json_manifest.cc:303:
GrabUrlAndCacheIdentity(isa_spec[kPnaclTranslateKey], url, cache_identity);
The if guard makes sure that the dictionary index here will return an empty
collection, I think.

http://codereview.chromium.org/9355051/diff/2001/ppapi/native_client/src/trus...
File ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc (right):

http://codereview.chromium.org/9355051/diff/2001/ppapi/native_client/src/trus...
ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc:223: 
stray character?

http://codereview.chromium.org/9355051/diff/2001/ppapi/native_client/src/trus...
File ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h (right):

http://codereview.chromium.org/9355051/diff/2001/ppapi/native_client/src/trus...
ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h:49: //     written
by: ld      (passed in explicitly through SRPC)
thanks for fixing my typing :-)

[jvoung - send to chromium..., 2012-02-22 19:45:36]

and now with cache lookup

http://codereview.chromium.org/9355051/diff/2001/ppapi/native_client/src/trus...
File ppapi/native_client/src/trusted/plugin/json_manifest.cc (right):

http://codereview.chromium.org/9355051/diff/2001/ppapi/native_client/src/trus...
ppapi/native_client/src/trusted/plugin/json_manifest.cc:303:
GrabUrlAndCacheIdentity(isa_spec[kPnaclTranslateKey], url, cache_identity);
On 2012/02/22 19:30:37, sehr wrote:
> The if guard makes sure that the dictionary index here will return an empty
> collection, I think.

Good catch thanks!  Copy-paste bug =(

http://codereview.chromium.org/9355051/diff/2001/ppapi/native_client/src/trus...
File ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc (right):

http://codereview.chromium.org/9355051/diff/2001/ppapi/native_client/src/trus...
ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc:223: 
On 2012/02/22 19:30:37, sehr wrote:
> stray character?

Done.

[sehr (please use chromium), 2012-02-22 21:45:53]

On 2012/02/22 19:45:36, jvoung wrote:
> and now with cache lookup
> 
>
http://codereview.chromium.org/9355051/diff/2001/ppapi/native_client/src/trus...
> File ppapi/native_client/src/trusted/plugin/json_manifest.cc (right):
> 
>
http://codereview.chromium.org/9355051/diff/2001/ppapi/native_client/src/trus...
> ppapi/native_client/src/trusted/plugin/json_manifest.cc:303:
> GrabUrlAndCacheIdentity(isa_spec[kPnaclTranslateKey], url, cache_identity);
> On 2012/02/22 19:30:37, sehr wrote:
> > The if guard makes sure that the dictionary index here will return an empty
> > collection, I think.
> 
> Good catch thanks!  Copy-paste bug =(
> 
>
http://codereview.chromium.org/9355051/diff/2001/ppapi/native_client/src/trus...
> File ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc (right):
> 
>
http://codereview.chromium.org/9355051/diff/2001/ppapi/native_client/src/trus...
> ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc:223: 
> On 2012/02/22 19:30:37, sehr wrote:
> > stray character?
> 
> Done.

LGTM.

[jvoung - send to chromium..., 2012-02-23 02:26:58]

On 2012/02/22 21:45:53, sehr wrote:
> On 2012/02/22 19:45:36, jvoung wrote:
> > and now with cache lookup
> > 
> >
>
http://codereview.chromium.org/9355051/diff/2001/ppapi/native_client/src/trus...
> > File ppapi/native_client/src/trusted/plugin/json_manifest.cc (right):
> > 
> >
>
http://codereview.chromium.org/9355051/diff/2001/ppapi/native_client/src/trus...
> > ppapi/native_client/src/trusted/plugin/json_manifest.cc:303:
> > GrabUrlAndCacheIdentity(isa_spec[kPnaclTranslateKey], url, cache_identity);
> > On 2012/02/22 19:30:37, sehr wrote:
> > > The if guard makes sure that the dictionary index here will return an
empty
> > > collection, I think.
> > 
> > Good catch thanks!  Copy-paste bug =(
> > 
> >
>
http://codereview.chromium.org/9355051/diff/2001/ppapi/native_client/src/trus...
> > File ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc (right):
> > 
> >
>
http://codereview.chromium.org/9355051/diff/2001/ppapi/native_client/src/trus...
> > ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc:223: 
> > On 2012/02/22 19:30:37, sehr wrote:
> > > stray character?
> > 
> > Done.
> 
> LGTM.

Thanks, trybots finally done -- 123178