Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Unified Diff: dart/frog/leg/ssa/nodes.dart

Issue 9355031: Improve List implementation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/frog/leg/ssa/nodes.dart
diff --git a/dart/frog/leg/ssa/nodes.dart b/dart/frog/leg/ssa/nodes.dart
index 0d7b4f125531863bd126db9ae7059388157619cf..bfd87faa20f0df9ff91a135af04d93812d7b5c7c 100644
--- a/dart/frog/leg/ssa/nodes.dart
+++ b/dart/frog/leg/ssa/nodes.dart
@@ -1091,7 +1091,8 @@ class HInvokeInterceptor extends HInvokeStatic {
accept(HVisitor visitor) => visitor.visitInvokeInterceptor(this);
HType computeType() {
- if (name == const SourceString('length') && inputs[1].isStringOrArray()) {
+ if (name == const SourceString('length') && inputs[1].isStringOrArray()
+ && inputs.length == 2) {
ngeoffray 2012/02/21 10:41:45 We could have a boolean setter in this class. It's
ahe 2012/02/21 23:03:25 There is a boolean "getter" which I can use.
ngeoffray 2012/02/22 08:52:04 Yes, but I think you're setting it to true in the
builtinJsName = 'length';
return HType.INTEGER;
} else if (name == const SourceString('add') && inputs[1].isArray()) {

Powered by Google App Engine
This is Rietveld 408576698