Improve List implementation.

dart/frog/leg/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaCodeGeneratorTask extends CompilerTask {
   SsaCodeGeneratorTask(Compiler compiler) : super(compiler);
   String get name() => 'SSA code generator';
 
   String generate(WorkItem work, HGraph graph) {
     return measure(() {
@@ skipping 676 matching lines @@
     buffer.add(';\n');
   }
 
   visitBoundsCheck(HBoundsCheck node) {
     buffer.add('if (');
     use(node.index, JSPrecedence.RELATIONAL_PRECEDENCE);
     buffer.add(' < 0 || ');
     use(node.index, JSPrecedence.RELATIONAL_PRECEDENCE);
     buffer.add(' >= ');
     use(node.length, JSPrecedence.SHIFT_PRECEDENCE);
-    buffer.add(") throw 'Out of bounds'");
+    buffer.add(") ");
+    generateFail('ioore', node.index);
   }
 
   visitIntegerCheck(HIntegerCheck node) {
     buffer.add('if (');
     use(node.value, JSPrecedence.EQUALITY_PRECEDENCE);
     buffer.add(' !== (');
     use(node.value, JSPrecedence.BITWISE_OR_PRECEDENCE);
-    buffer.add(" | 0)) throw 'Illegal argument'");
+    buffer.add(" | 0)) ");
+    generateFail('iae', node.value);
+  }
+
+  void generateFail(String helperName, HInstruction argument) {
+    Element helper = compiler.findHelper(new SourceString(helperName));
+    compiler.registerStaticUse(helper);
+    buffer.add('throw ');
+    beginExpression(JSPrecedence.EXPRESSION_PRECEDENCE);
+    beginExpression(JSPrecedence.CALL_PRECEDENCE);
+    buffer.add(compiler.namer.isolateAccess(helper));
+    visitArguments([null, argument]);
+    endExpression(JSPrecedence.CALL_PRECEDENCE);
+    endExpression(JSPrecedence.EXPRESSION_PRECEDENCE);
   }
 
   void addIndentation() {
     for (int i = 0; i < indent; i++) {
       buffer.add('  ');
     }
   }
 
   void visitStatic(HStatic node) {
     compiler.registerStaticUse(node.element);
@@ skipping 526 matching lines @@
       startBailoutSwitch();
     }
   }
 
   void endElse(HIf node) {
     if (node.elseBlock.hasBailouts()) {
       endBailoutSwitch();
     }
   }
 }