Improve List implementation.

dart/frog/leg/ssa/builder.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Interceptors {
   Compiler compiler;
   Interceptors(Compiler this.compiler);
 
   SourceString mapOperatorToMethodName(Operator op) {
     String name = op.source.stringValue;
@@ skipping 37 matching lines @@
     Element result = compiler.findHelper(new SourceString(mangledName));
     return result;
   }
 
   Element getStaticGetInterceptor(SourceString name) {
     String mangledName = "builtin\$get\$${name}";
     Element result = compiler.findHelper(new SourceString(mangledName));
     return result;
   }
 
+  Element getStaticSetInterceptor(SourceString name) {
+    String mangledName = "builtin\$set\$${name}";
+    Element result = compiler.findHelper(new SourceString(mangledName));
+    return result;
+  }
+
   Element getOperatorInterceptor(Operator op) {
     SourceString name = mapOperatorToMethodName(op);
     Element result = compiler.findHelper(name);
     return result;
   }
 
   Element getPrefixOperatorInterceptor(Operator op) {
     String name = op.source.stringValue;
     if (name === '~') {
       return compiler.findHelper(const SourceString('not'));
@@ skipping 1218 matching lines @@
       stack.add(value);
     } else if (element === null || Elements.isInstanceField(element)) {
       SourceString dartSetterName = send.selector.asIdentifier().source;
       HInstruction receiver;
       if (send.receiver == null) {
         receiver = localsHandler.readThis();
       } else {
         visit(send.receiver);
         receiver = pop();
       }
-      add(new HInvokeDynamicSetter(
-          selector, null, dartSetterName, receiver, value));
+      Element staticInterceptor = null;
+      if (methodInterceptionEnabled) {

[kasperl, 2012/02/21 07:16:43]

Would it make sense to move the methodInterceptionEnabled flag to the
interceptors object?

[ngeoffray, 2012/02/21 10:41:45]

I decided to put it on the compiler because the interceptors object felt like
something that does not have state.

[ahe, 2012/02/21 23:03:25]

I'll stay out of this discussion. It seems to me that this flag is temporary.

[ngeoffray, 2012/02/22 08:52:04]

Why do you think it's temporary? The flag is for implementing UNINTERCEPTED.

[ahe, 2012/02/22 08:58:30]

I see. Another reason for me to stay out of this discussion. I only have a
cursory understanding of this code :-)

+        staticInterceptor =
+          interceptors.getStaticSetInterceptor(dartSetterName);
+      }
+      if (staticInterceptor != null) {
+        HStatic target = new HStatic(staticInterceptor);
+        add(target);
+        List<HInstruction> inputs = <HInstruction>[target, receiver, value];
+        add(new HInvokeInterceptor(selector, dartSetterName, true, inputs));
+      } else {
+        add(new HInvokeDynamicSetter(selector, null, dartSetterName,
+                                     receiver, value));
+      }
       stack.add(value);
     } else {
       localsHandler.updateLocal(element, value);
       stack.add(value);
     }
   }
 
   visitOperatorSend(node) {
     assert(node.selector is Operator);
     Operator op = node.selector;
@@ skipping 771 matching lines @@
   }
 
   visitCatchBlock(CatchBlock node) {
     visit(node.block);
   }
 
   visitTypedef(Typedef node) {
     compiler.unimplemented('SsaBuilder.visitTypedef', node: node);
   }
 }