Issue 9355015: Add 4068 to the list of warnings to suppress in VS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9355015: Add 4068 to the list of warnings to suppress in VS. (Closed)

Created:
8 years, 10 months ago by jungshik at Google

Modified:
8 years, 10 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/deps/third_party/icu46/

Visibility:
Public.

More Reviews

Description

Add 4068 to the list of warnings to suppress in VS. We added pragmas to disable warnings from clang to i18n/decNum.c. They're not recognized by Visual Studio. To suppress that warning, add 4068 to the suppressed VC warning list. BUG=84851 TEST=Visual Stuido doesn't complain while compiling decNumc. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122609

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	icu.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jungshik at Google

I'll roll ICU to a revision with this change.

8 years, 10 months ago (2012-02-17 22:44:23 UTC) #1

lgtm

sigh :-/

Expand Messages | Collapse Messages