Source/WebCore/bindings/v8/custom/V8CustomVoidCallback.cpp - Issue 9355009: Merge 107170 - DOM mutations should not be delivered on worker threads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/bindings/v8/custom/V8CustomVoidCallback.cpp

Issue 9355009: Merge 107170 - DOM mutations should not be delivered on worker threads (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1025/

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/WebCore/bindings/v8/V8WindowErrorHandler.cpp ('k') | Source/WebCore/bindings/v8/custom/V8CustomXPathNSResolver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/bindings/v8/custom/V8CustomVoidCallback.cpp

===================================================================

--- Source/WebCore/bindings/v8/custom/V8CustomVoidCallback.cpp (revision 108090)

+++ Source/WebCore/bindings/v8/custom/V8CustomVoidCallback.cpp (working copy)

@@ -83,8 +83,8 @@

v8::Handle<v8::Object> thisObject = v8::Context::GetCurrent()->Global();

- Page* page = scriptExecutionContext && scriptExecutionContext->isDocument() ? static_cast<Document*>(scriptExecutionContext)->page() : 0;

- v8::Handle<v8::Value> result = V8Proxy::instrumentedCallFunction(page, callbackFunction, thisObject, argc, argv);

+ Frame* frame = scriptExecutionContext && scriptExecutionContext->isDocument() ? static_cast<Document*>(scriptExecutionContext)->frame() : 0;

+ v8::Handle<v8::Value> result = V8Proxy::instrumentedCallFunction(frame, callbackFunction, thisObject, argc, argv);

callbackReturnValue = !result.IsEmpty() && result->BooleanValue();

return exceptionCatcher.HasCaught();