Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: device/bluetooth/bluetooth_adapter_chromeos.h

Issue 935383003: Fix BluetoothAdapterProfileChromeOS lifecycle management (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: further fix ownership, address comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_adapter_chromeos.h
diff --git a/device/bluetooth/bluetooth_adapter_chromeos.h b/device/bluetooth/bluetooth_adapter_chromeos.h
index 12a88f9bbff9a13e1f526f28013b77773e23e2a0..1287c899e5e6714196586c87d1ddc1b0cf7d78a0 100644
--- a/device/bluetooth/bluetooth_adapter_chromeos.h
+++ b/device/bluetooth/bluetooth_adapter_chromeos.h
@@ -138,8 +138,9 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothAdapterChromeOS
const ProfileRegisteredCallback& success_callback,
const ErrorCompletionCallback& error_callback);
- // Releases the profile associated with |uuid|
- void ReleaseProfile(const device::BluetoothUUID& uuid);
+ // Release use of a profile by a device
Ilya Sherman 2015/02/21 01:22:10 nit: Please end the sentence with a period.
Marie Janssen 2015/02/23 17:49:09 Done.
+ void ReleaseProfile(const dbus::ObjectPath& device_path,
+ BluetoothAdapterProfileChromeOS* profile);
protected:
// BluetoothAdapter:
@@ -283,6 +284,10 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothAdapterChromeOS
const std::string& error_name,
const std::string& error_message);
+ // Called by BluetoothAdapterProfileChromeOS when there no users of a profile
Ilya Sherman 2015/02/21 01:22:10 nit: s/there//
Marie Janssen 2015/02/23 17:49:09 Done.
+ // remain.
+ void RemoveProfile(const device::BluetoothUUID& uuid);
+
// Processes the queued discovery requests. For each DiscoveryCallbackPair in
// the queue, this method will try to add a new discovery session. This method
// is called whenever a pending D-Bus call to start or stop discovery has
« no previous file with comments | « no previous file | device/bluetooth/bluetooth_adapter_chromeos.cc » ('j') | device/bluetooth/bluetooth_adapter_chromeos.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698