Issue 9353006: Increase size of small stacks from 32k to 64k to avoid hitting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9353006: Increase size of small stacks from 32k to 64k to avoid hitting (Closed)

Created:
8 years, 10 months ago by Erik Corry

Modified:
8 years, 10 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Increase size of small stacks from 32k to 64k to avoid hitting limits in Chromium. http://code.google.com/p/chromium/issues/detail?id=112843 Committed: https://code.google.com/p/v8/source/detail?r=10615

Patch Set 1 #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -11 lines)			Patch
M	src/cpu-profiler.cc	View	1 chunk	+1 line, -1 line	1 comment	Download
M	src/platform-freebsd.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform-linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform-macos.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform-openbsd.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform-solaris.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform-win32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-mark-compact.cc	View	1 chunk	+4 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 10 months ago (2012-02-07 07:44:01 UTC) #2

LGTM.

https://chromiumcodereview.appspot.com/9353006/diff/1/src/cpu-profiler.cc
File src/cpu-profiler.cc (right):

https://chromiumcodereview.appspot.com/9353006/diff/1/src/cpu-profiler.cc#new...
src/cpu-profiler.cc:1: // Copyright 2010 the V8 project authors. All rights
reserved.
nit: 2012

https://chromiumcodereview.appspot.com/9353006/diff/1/test/cctest/test-mark-c...
File test/cctest/test-mark-compact.cc (right):

https://chromiumcodereview.appspot.com/9353006/diff/1/test/cctest/test-mark-c...
test/cctest/test-mark-compact.cc:1: // Copyright 2006-2008 the V8 project
authors. All rights reserved.
nit: 2012

Expand Messages | Collapse Messages