Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 9353005: Revert 120698 - [Sync] Fix thread-ordering-dependent NULL dereference in NewNonFrontendDTC (Closed)

Created:
8 years, 10 months ago by akalin
Modified:
8 years, 10 months ago
Reviewers:
akalin
CC:
chromium-reviews, GeorgeY, ncarter (slow), akalin, Raghu Simha, dyu1, dhollowa+watch_chromium.org, Ilya Sherman, tim (not reviewing)
Visibility:
Public.

Description

Revert 120698 - [Sync] Fix thread-ordering-dependent NULL dereference in NewNonFrontendDTC Re-enable migration tests that were affected. Rewrite autofill DTC tests. BUG=107743 TEST= Review URL: https://chromiumcodereview.appspot.com/9307079 TBR=akalin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120700

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -288 lines) Patch
M chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc View 1 chunk +119 lines, -104 lines 0 comments Download
M chrome/browser/sync/glue/new_non_frontend_data_type_controller.h View 2 chunks +15 lines, -27 lines 0 comments Download
M chrome/browser/sync/glue/new_non_frontend_data_type_controller.cc View 11 chunks +37 lines, -59 lines 0 comments Download
M chrome/browser/sync/glue/new_non_frontend_data_type_controller_unittest.cc View 7 chunks +1 line, -74 lines 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller.h View 5 chunks +16 lines, -21 lines 0 comments Download
M chrome/browser/sync/test/integration/migration_errors_test.cc View 3 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
akalin
8 years, 10 months ago (2012-02-07 03:27:31 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698