Fix split with regexp for frog.

tests/corelib/src/StringSplitTest.dart

Index: tests/corelib/src/StringSplitTest.dart
diff --git a/tests/corelib/src/StringSplitTest.dart b/tests/corelib/src/StringSplitTest.dart
index 7cacc7c59e682f6c0691a863837b99bceac12349..10662139e90b771072f6fab913acb53f2846ff14 100644
--- a/tests/corelib/src/StringSplitTest.dart
+++ b/tests/corelib/src/StringSplitTest.dart
@@ -1,46 +1,87 @@
-// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-class StringSplitTest {
-  static testMain() {
-    var list = "a b c".split(" ");
-    Expect.equals(3, list.length);
-    Expect.equals("a", list[0]);
-    Expect.equals("b", list[1]);
-    Expect.equals("c", list[2]);
-
-    list = "adbdc".split("d");
-    Expect.equals(3, list.length);
-    Expect.equals("a", list[0]);
-    Expect.equals("b", list[1]);
-    Expect.equals("c", list[2]);
-
-    list = "addbddc".split("dd");
-    Expect.equals(3, list.length);
-    Expect.equals("a", list[0]);
-    Expect.equals("b", list[1]);
-    Expect.equals("c", list[2]);
-
-    list = "abc".split(" ");
-    Expect.equals(1, list.length);
-    Expect.equals("abc", list[0]);
-
-    list = "abc".split("");
-    Expect.equals(3, list.length);
-    Expect.equals("a", list[0]);
-    Expect.equals("b", list[1]);
-    Expect.equals("c", list[2]);
-
-    list = "   ".split(" ");
-    Expect.equals(4, list.length);
-    Expect.equals("", list[0]);
-    Expect.equals("", list[1]);
-    Expect.equals("", list[2]);
-    Expect.equals("", list[3]);
-  }
+splitString() {

[kasperl, 2012/02/07 12:32:30]

testSplitString?

[floitsch, 2012/02/07 15:06:29]

kept original file as is.

+  var list = "a b c".split(" ");
+  Expect.equals(3, list.length);
+  Expect.equals("a", list[0]);
+  Expect.equals("b", list[1]);
+  Expect.equals("c", list[2]);
+
+  list = "adbdc".split("d");
+  Expect.equals(3, list.length);
+  Expect.equals("a", list[0]);
+  Expect.equals("b", list[1]);
+  Expect.equals("c", list[2]);
+
+  list = "addbddc".split("dd");
+  Expect.equals(3, list.length);
+  Expect.equals("a", list[0]);
+  Expect.equals("b", list[1]);
+  Expect.equals("c", list[2]);
+
+  list = "abc".split(" ");
+  Expect.equals(1, list.length);
+  Expect.equals("abc", list[0]);
+
+  list = "abc".split("");
+  Expect.equals(3, list.length);
+  Expect.equals("a", list[0]);
+  Expect.equals("b", list[1]);
+  Expect.equals("c", list[2]);
+
+  list = "   ".split(" ");
+  Expect.equals(4, list.length);
+  Expect.equals("", list[0]);
+  Expect.equals("", list[1]);
+  Expect.equals("", list[2]);
+  Expect.equals("", list[3]);
+}
+
+splitRegExp() {

[kasperl, 2012/02/07 12:32:30]

testSplitRegExp?

[kasperl, 2012/02/07 12:34:09]

Maybe it would be even better to add this in a new file so you don't lose the
VMs test coverage on the string splitting implementation?

[floitsch, 2012/02/07 15:06:29]

Done.

[floitsch, 2012/02/07 15:06:29]

now in main().

+  var list = "a b c".split(const RegExp(" "));
+  Expect.equals(3, list.length);
+  Expect.equals("a", list[0]);
+  Expect.equals("b", list[1]);
+  Expect.equals("c", list[2]);
+
+  list = "adbdc".split(const RegExp("[dz]"));
+  Expect.equals(3, list.length);
+  Expect.equals("a", list[0]);
+  Expect.equals("b", list[1]);
+  Expect.equals("c", list[2]);
+
+  list = "addbddc".split(new RegExp("dd"));
+  Expect.equals(3, list.length);
+  Expect.equals("a", list[0]);
+  Expect.equals("b", list[1]);
+  Expect.equals("c", list[2]);
+
+  list = "abc".split(new RegExp(@"b$"));
+  Expect.equals(1, list.length);
+  Expect.equals("abc", list[0]);
+
+  list = "abc".split(new RegExp(""));
+  Expect.equals(3, list.length);
+  Expect.equals("a", list[0]);
+  Expect.equals("b", list[1]);
+  Expect.equals("c", list[2]);
+
+  list = "   ".split(const RegExp("[ ]"));
+  Expect.equals(4, list.length);
+  Expect.equals("", list[0]);
+  Expect.equals("", list[1]);
+  Expect.equals("", list[2]);
+  Expect.equals("", list[3]);
+
+  list = "aaa".split(const RegExp(@"a$"));
+  Expect.equals(2, list.length);
+  Expect.equals("aa", list[0]);
+  Expect.equals("", list[1]);
 }
 
 main() {
-  StringSplitTest.testMain();
+  splitString();
+  splitRegExp();
 }