Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: frog/world.dart

Issue 9352016: Fix split with regexp for frog. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Use existing style. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/lib/string_implementation.dart ('k') | tests/corelib/corelib.status » ('j') | tests/corelib/src/StringSplitTest.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/world.dart
diff --git a/frog/world.dart b/frog/world.dart
index e20bc1c22e76fbc95e3eacc1465b10a2d2357234..e53e36d889a8e27d0660f616f0b5592922917389 100644
--- a/frog/world.dart
+++ b/frog/world.dart
@@ -330,6 +330,9 @@ class World {
'class', 'enum', 'export', 'extends', 'import', 'super',
'implements', 'interface', 'let', 'package', 'private',
'protected', 'public', 'static', 'yield',
+ // Hack: we don't want Dart's String.split to overwrite the existing
kasperl 2012/02/07 12:32:30 Maybe explain this a bit better. Elaborate.
floitsch 2012/02/07 15:06:29 Done.
+ // split method.
+ 'split',
'native']);
}
if (_jsKeywords.contains(name)) {
« no previous file with comments | « frog/lib/string_implementation.dart ('k') | tests/corelib/corelib.status » ('j') | tests/corelib/src/StringSplitTest.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698