Issue 9352013: Extend scanner with new Harmony module keywords (under flag).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9352013: Extend scanner with new Harmony module keywords (under flag). (Closed)

Created:
8 years, 10 months ago by rossberg

Modified:
8 years, 10 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Extend scanner with new Harmony module keywords (under flag). R=mstarzinger@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10638

Patch Set 2 : Addressed Michael's comments. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -16 lines)			Patch
M	src/flag-definitions.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/parser.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/parser.cc	View	1	3 chunks	+9 lines, -1 line	0 comments	Download
M	src/preparser.h	View		4 chunks	+7 lines, -3 lines	0 comments	Download
M	src/scanner.h	View	1	3 chunks	+14 lines, -6 lines	0 comments	Download
M	src/scanner.cc	View		5 chunks	+13 lines, -5 lines	0 comments	Download
M	src/token.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with nits). https://chromiumcodereview.appspot.com/9352013/diff/1/src/scanner.h File src/scanner.h (right): https://chromiumcodereview.appspot.com/9352013/diff/1/src/scanner.h#newcode56 src/scanner.h:56: kAllowModules = 16 Can we either ...

8 years, 10 months ago (2012-02-07 14:50:59 UTC) #2

rossberg

8 years, 10 months ago (2012-02-08 10:32:42 UTC) #3

https://chromiumcodereview.appspot.com/9352013/diff/1/src/scanner.h
File src/scanner.h (right):

https://chromiumcodereview.appspot.com/9352013/diff/1/src/scanner.h#newcode56
src/scanner.h:56: kAllowModules = 16
On 2012/02/07 14:50:59, Michael Starzinger wrote:
> Can we either change this constant (and the two above) to "1 << 4" or to
"0x10"?
> I think that's more readable.

Done.

https://chromiumcodereview.appspot.com/9352013/diff/1/src/scanner.h#newcode564
src/scanner.h:564: // Whether we scan 'module', 'import', 'export', and 'from'
as keywords.
On 2012/02/07 14:50:59, Michael Starzinger wrote:
> I don't see "from" being a keyword in the scanner.

Oops, leftover.

Expand Messages | Collapse Messages

Issue 9352013: Extend scanner with new Harmony module keywords (under flag). (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed Michael's comments. #

Messages