Issue 9352010: Settings: Shake the overlay when the user clicks on the overlay shield.

Issue 9352010: Settings: Shake the overlay when the user clicks on the overlay shield. (Closed)

Created:
8 years, 10 months ago by James Hawkins

Modified:
8 years, 10 months ago

Reviewers:
csilv

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Settings: Shake the overlay when the user clicks on the overlay shield. BUG=111879 TEST=none R=csilv Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120819

Patch Set 2 : Review fix. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -1 line)			Patch
	M	chrome/browser/resources/options2/options_page.js	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download
	M	chrome/browser/resources/shared/css/overlay.css	View		2 chunks	+22 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

csilv

https://chromiumcodereview.appspot.com/9352010/diff/1/chrome/browser/resources/options2/options_page.js File chrome/browser/resources/options2/options_page.js (right): https://chromiumcodereview.appspot.com/9352010/diff/1/chrome/browser/resources/options2/options_page.js#newcode684 chrome/browser/resources/options2/options_page.js:684: }, SHAKE_DURATION_MS); Instead of using a timeout, have you ...

8 years, 10 months ago (2012-02-07 18:57:33 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jhawkins@chromium.org/9352010/3001

8 years, 10 months ago (2012-02-07 19:56:54 UTC) #4

James Hawkins

8 years, 10 months ago (2012-02-07 20:15:36 UTC) #5

https://chromiumcodereview.appspot.com/9352010/diff/1/chrome/browser/resource...
File chrome/browser/resources/options2/options_page.js (right):

https://chromiumcodereview.appspot.com/9352010/diff/1/chrome/browser/resource...
chrome/browser/resources/options2/options_page.js:684: }, SHAKE_DURATION_MS);
On 2012/02/07 18:57:33, csilv wrote:
> Instead of using a timeout, have you considered using an animation end
function?
>  something like:
> 
> page.classList.addEventListener("webkitAnimationEnd", function(){
>     page.classList.remove('shake');
> }, false);

Done.

Expand Messages | Collapse Messages