Issue 9352006: Another revert of change caused by bad merge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9352006: Another revert of change caused by bad merge. (Closed)

Created:
8 years, 10 months ago by oshima

Modified:
8 years, 10 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Another revert of change caused by bad merge. TBR=ben@chromium.org BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120699

Patch Set 1 : revert bad merge #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	ui/views/widget/native_widget_aura.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

8 years, 10 months ago (2012-02-07 03:46:10 UTC) #2

LGTM

On Mon, Feb 6, 2012 at 7:11 PM, <oshima@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Another revert of change caused by bad merge.
>
> TBR=ben@chromium.org
> BUG=none
> TEST=none
>
> Committed: https://src.chromium.org/**viewvc/chrome?view=rev&**
>
revision=120699<https://src.chromium.org/viewvc/chrome?view=rev&revision=120699>
>
> Please review this at
https://chromiumcodereview.**appspot.com/9352006/<https://chromiumcodereview....
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M ui/views/widget/native_widget_**aura.cc
>
>
> Index: ui/views/widget/native_widget_**aura.cc
> diff --git a/ui/views/widget/native_**widget_aura.cc
> b/ui/views/widget/native_**widget_aura.cc
> index 5e66c6c8961da57bf4d4a9a8f57a00**e94d7ddd0b..**
> d2970f1c7b47a380b9ff5d37ab158b**f2fee9ed7d 100644
> --- a/ui/views/widget/native_**widget_aura.cc
> +++ b/ui/views/widget/native_**widget_aura.cc
> @@ -729,6 +729,9 @@ void NativeWidgetAura::**OnWindowDestroying() {
>
>   // If the aura::Window is destroyed, we can no longer show tooltips.
>   tooltip_manager_.reset();
> +
> +  // Cleanup properties associated with the window here.
> +  delete GetRestoreBounds(window_);
>  }
>
>  void NativeWidgetAura::**OnWindowDestroyed() {
>
>
>

Expand Messages | Collapse Messages