Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: frog/leg/warnings.dart

Issue 9351020: Implement try/catch without finally, and without type checks. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: frog/leg/warnings.dart
===================================================================
--- frog/leg/warnings.dart (revision 3986)
+++ frog/leg/warnings.dart (working copy)
@@ -86,6 +86,12 @@
'#{1} is not an instance field');
static final EXPECTED_LITERAL_NUMBER = const MessageKind(
'expected a literal number after +');
+ static final NO_CATCH_NOR_FINALLY = const MessageKind(
+ 'expected a catch block or finally block after a try block');
ahe 2012/02/07 19:10:35 I suggest shortening this error to: expected 'cat
ngeoffray 2012/02/08 09:52:23 Done.
+ static final EMPTY_CATCH_DECLARATION = const MessageKind(
+ 'expected a variable in a catch declaration');
+ static final TOO_MANY_CATCH_DECLARATIONS = const MessageKind(
+ 'too many variables in a catch declaration');
ahe 2012/02/07 19:10:35 I'd stick to the singular case and report one erro
ngeoffray 2012/02/08 09:52:23 Done.
static final NOT_A_COMPILE_TIME_CONSTANT = const MessageKind(
'#{1} cannot be used as compile-time constant');

Powered by Google App Engine
This is Rietveld 408576698