Mac app mode: locate Chrome + refactor

chrome/common/mac/app_mode_chrome_locator_unittest.mm

Index: chrome/common/mac/app_mode_chrome_locator_unittest.mm
diff --git a/chrome/common/mac/app_mode_chrome_locator_unittest.mm b/chrome/common/mac/app_mode_chrome_locator_unittest.mm
new file mode 100644
index 0000000000000000000000000000000000000000..b54fee7553878c14e7cb909c54759dd2b1793629
--- /dev/null
+++ b/chrome/common/mac/app_mode_chrome_locator_unittest.mm
@@ -0,0 +1,68 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import "chrome/common/mac/app_mode_chrome_locator.h"
+
+#include <CoreFoundation/CoreFoundation.h>
+
+#include "base/file_path.h"
+#include "base/file_util.h"
+#include "base/path_service.h"
+#include "base/scoped_temp_dir.h"
+#include "chrome/common/chrome_constants.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+// Return the path to the Chrome/Chromium app bundle compiled along with the
+// test executable.
+void GetChromeBundlePath(FilePath* chrome_bundle) {
+  FilePath path;
+  PathService::Get(base::DIR_EXE, &path);
+  path = path.Append(chrome::kBrowserProcessExecutableNameChromium);
+  path = path.ReplaceExtension(FilePath::StringType("app"));
+  *chrome_bundle = path;
+}
+
+}  // namespace
+
+TEST(ChromeLocatorTest, FindBundle) {
+  FilePath finder_bundle_path;
+  EXPECT_TRUE(
+      app_mode::FindBundleById(@"com.apple.finder", &finder_bundle_path));
+  EXPECT_TRUE(file_util::DirectoryExists(finder_bundle_path));
+}
+
+TEST(ChromeLocatorTest, FindNonExistentBundle) {
+  FilePath dummy;
+  EXPECT_FALSE(app_mode::FindBundleById(@"this.doesnt.exist", &dummy));
+}
+
+TEST(ChromeLocatorTest, GetNonExistentBundleInfo) {
+  ScopedTempDir temp_dir;
+  ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
+
+  string16 raw_version;
+  FilePath version_path;
+  FilePath framework_path;
+  EXPECT_FALSE(app_mode::GetChromeBundleInfo(temp_dir.path(),
+      &raw_version, &version_path, &framework_path));
+}
+
+TEST(ChromeLocatorTest, GetChromeBundleInfo) {
+  using app_mode::GetChromeBundleInfo;
+
+  FilePath chrome_bundle_path;
+  GetChromeBundlePath(&chrome_bundle_path);
+  ASSERT_TRUE(file_util::DirectoryExists(chrome_bundle_path));
+
+  string16 raw_version;
+  FilePath version_path;
+  FilePath framework_path;
+  EXPECT_TRUE(GetChromeBundleInfo(chrome_bundle_path,
+      &raw_version, &version_path, &framework_path));
+  EXPECT_GT(raw_version.size(), 0U);
+  EXPECT_TRUE(file_util::DirectoryExists(version_path));
+  EXPECT_TRUE(file_util::PathExists(framework_path));
+}