Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 9351004: Reverting Gyp simplifications in chrome/chrome_browser.gypi (Closed)

Created:
8 years, 10 months ago by Emmanuel Saint-loubert-Bié
Modified:
8 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, piman
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -73 lines) Patch
M build/common.gypi View 4 chunks +24 lines, -17 lines 0 comments Download
M chrome/chrome_browser.gypi View 8 chunks +131 lines, -56 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Emmanuel Saint-loubert-Bié
8 years, 10 months ago (2012-02-07 01:16:09 UTC) #1
Lei Zhang
If this is a straight-up revert, then LGTM. I thought CrOS wants to build without ...
8 years, 10 months ago (2012-02-07 01:19:05 UTC) #2
Emmanuel Saint-loubert-Bié
Hi Lei, We do, the issue is that we still need to support ChromeOS+GTK in ...
8 years, 10 months ago (2012-02-07 01:20:35 UTC) #3
commit-bot: I haz the power
8 years, 10 months ago (2012-02-07 01:27:32 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698