Issue 9350029: Fix pyauto functional tests on chromeos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9350029: Fix pyauto functional tests on chromeos (Closed)

Created:
8 years, 10 months ago by Nirnimesh

Modified:
8 years, 10 months ago

Reviewers:
krisr

CC:
chromium-reviews, dennis_jeffrey, John Grabowski, anantha, dyu1, Nirnimesh

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix pyauto functional tests on chromeos TBR=krisr@chromium.org R=krisr@chromium.org BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120828

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/test/functional/PYAUTO_TESTS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

krisr

8 years, 10 months ago (2012-02-07 22:18:38 UTC) #2

LGTM

On Tue, Feb 7, 2012 at 1:52 PM, <nirnimesh@chromium.org> wrote:

> Reviewers: krisr,
>
> Description:
> Fix pyauto functional tests on chromeos
>
>
> TBR=krisr@chromium.org
> R=krisr@chromium.org
> BUG=
> TEST=
>
>
> Please review this at
https://chromiumcodereview.**appspot.com/9350029/<https://chromiumcodereview....
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/test/functional/PYAUTO_**TESTS
>
>
> Index: chrome/test/functional/PYAUTO_**TESTS
> diff --git a/chrome/test/functional/**PYAUTO_TESTS
> b/chrome/test/functional/**PYAUTO_TESTS
> index 4cca8a4e6ed27bc440f7366cb220a7**3778b4318f..**
> ad564188a06ea76599e0b16dfd7065**ec8a9cae59 100644
> --- a/chrome/test/functional/**PYAUTO_TESTS
> +++ b/chrome/test/functional/**PYAUTO_TESTS
> @@ -293,7 +293,7 @@
>       # No Web Driver test for ChromeOS.
>       '-about_plugins_ui',
>       # You cannot adjust the downloads directory on ChromeOS.
> -      '-prefs.PrefsTest.**testDownloadDirPref'
> +      '-prefs.PrefsTest.**testDownloadDirPref',
>
>       # ==============================**====================
>       # Disabled tests that need to be investigated/fixed.
>
>
>

Expand Messages | Collapse Messages