Issue 9350024: Unrevert again r119770 - "Event pages: remember events that the page registered for,""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9350024: Unrevert again r119770 - "Event pages: remember events that the page registered for,"" (Closed)

Created:
8 years, 10 months ago by Matt Perry

Modified:
8 years, 10 months ago

Reviewers:
aa

CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Unrevert again r119770 - "Event pages: remember events that the page registered for,"" Original CL: Add support for broadcasted events. Add an extension.onInstalled event that is run when the event page first starts." Fixed ASAN bug with previous incarnation. Previous revert did not fix failing tests, so it's going back in. TBR=aa BUG=81752, 112391 TEST=no Review URL: https://chromiumcodereview.appspot.com/9350006 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120808

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+294 lines, -89 lines)			Patch
M	chrome/browser/extensions/extension_event_router.h	View	3 chunks	+27 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_event_router.cc	View	14 chunks	+86 lines, -47 lines	0 comments	Download
M	chrome/browser/extensions/extension_host.cc	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_process_manager.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_process_manager.cc	View	3 chunks	+20 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/lazy_background_page_apitest.cc	View	5 chunks	+62 lines, -27 lines	0 comments	Download
M	chrome/browser/renderer_host/chrome_render_message_filter.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/chrome_render_message_filter.cc	View	3 chunks	+20 lines, -0 lines	0 comments	Download
M	chrome/common/common_resources.grd	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/common/extensions/api/experimental.extension.json	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/experimental.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/js/api_page_generator.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_messages.h	View	2 chunks	+13 lines, -1 line	0 comments	Download
M	chrome/renderer/extensions/event_bindings.cc	View	3 chunks	+12 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/lazy_background_page/broadcast_event/background.js	View	1 chunk	+2 lines, -3 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/lazy_background_page/on_installed/background.js	View	1 chunk	+7 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/lazy_background_page/on_installed/manifest.json	View	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages