Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: chrome/browser/extensions/extension_event_router.h

Issue 9350006: Revert "Unrevert 119770 - "Event pages: remember events that the page registered for," (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_event_router.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_event_router.h
diff --git a/chrome/browser/extensions/extension_event_router.h b/chrome/browser/extensions/extension_event_router.h
index b142198338a761bed5ea9089ed0a3e61dfad1b4a..6624d98efdf0a1dc2a83a6b6d04c3eefc7f00ea3 100644
--- a/chrome/browser/extensions/extension_event_router.h
+++ b/chrome/browser/extensions/extension_event_router.h
@@ -50,15 +50,6 @@ class ExtensionEventRouter : public content::NotificationObserver {
content::RenderProcessHost* process,
const std::string& extension_id);
- // Add or remove the extension as having a lazy background page that listens
- // to the event. The difference from the above methods is that these will be
- // remembered even after the process goes away. We use this list to decide
- // which extension pages to load when dispatching an event.
- void AddLazyEventListener(const std::string& event_name,
- const std::string& extension_id);
- void RemoveLazyEventListener(const std::string& event_name,
- const std::string& extension_id);
-
// Returns true if there is at least one listener for the given event.
bool HasEventListener(const std::string& event_name);
@@ -114,25 +105,15 @@ class ExtensionEventRouter : public content::NotificationObserver {
// Shared by DispatchEvent*. If |extension_id| is empty, the event is
// broadcast.
// An event that just came off the pending list may not be delayed again.
- void DispatchEventImpl(const std::string& extension_id,
- const linked_ptr<ExtensionEvent>& event,
+ void DispatchEventImpl(const linked_ptr<ExtensionEvent>& event,
bool was_pending);
- // Ensures that all non-persistent background pages that are interested in the
- // given event are loaded, and queues the event if the page is not ready yet.
- // If |extension_id| is non-empty, we load only that extension's page
- // (assuming it is interested in the event).
- void LoadLazyBackgroundPagesForEvent(
- const std::string& extension_id,
- const linked_ptr<ExtensionEvent>& event);
-
// Dispatch may be delayed if the extension has a lazy background page.
- bool CanDispatchEventNow(const Extension* extension);
+ bool CanDispatchEventNow(const std::string& extension_id);
// Store the event so that it can be dispatched (in order received)
// when the background page is done loading.
- void AppendEvent(const std::string& extension_id,
- const linked_ptr<ExtensionEvent>& event);
+ void AppendEvent(const linked_ptr<ExtensionEvent>& event);
void DispatchPendingEvents(const std::string& extension_id);
private:
@@ -154,11 +135,6 @@ class ExtensionEventRouter : public content::NotificationObserver {
typedef std::map<std::string, std::set<EventListener> > ListenerMap;
ListenerMap listeners_;
- // Keeps track of all the non-persistent background pages that are listening
- // to events.
- // TODO(mpcomplete): save to disk.
- ListenerMap lazy_listeners_;
-
// A map between an extension id and the queue of events pending
// the load of it's background page.
typedef std::vector<linked_ptr<ExtensionEvent> > PendingEventsList;
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_event_router.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698