Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Side by Side Diff: chrome/renderer/extensions/event_bindings.cc

Issue 9350006: Revert "Unrevert 119770 - "Event pages: remember events that the page registered for," (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/event_bindings.h" 5 #include "chrome/renderer/extensions/event_bindings.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
11 #include "base/message_loop.h" 11 #include "base/message_loop.h"
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 v8_extension->extension_dispatcher()->v8_context_set(); 84 v8_extension->extension_dispatcher()->v8_context_set();
85 ChromeV8Context* context = context_set.GetCurrent(); 85 ChromeV8Context* context = context_set.GetCurrent();
86 CHECK(context); 86 CHECK(context);
87 EventListenerCounts& listener_counts = 87 EventListenerCounts& listener_counts =
88 GetListenerCounts(context->extension_id()); 88 GetListenerCounts(context->extension_id());
89 std::string event_name(*v8::String::AsciiValue(args[0])); 89 std::string event_name(*v8::String::AsciiValue(args[0]));
90 90
91 if (!v8_extension->CheckCurrentContextAccessToExtensionAPI(event_name)) 91 if (!v8_extension->CheckCurrentContextAccessToExtensionAPI(event_name))
92 return v8::Undefined(); 92 return v8::Undefined();
93 93
94 const ::Extension* extension = v8_extension->extension_dispatcher()->
95 extensions()->GetByID(context->extension_id());
96
97 if (++listener_counts[event_name] == 1) { 94 if (++listener_counts[event_name] == 1) {
98 content::RenderThread::Get()->Send( 95 content::RenderThread::Get()->Send(
99 new ExtensionHostMsg_AddListener(context->extension_id(), 96 new ExtensionHostMsg_AddListener(context->extension_id(),
100 event_name)); 97 event_name));
101 // TODO(mpcomplete): restrict this to the bg page only.
102 // TODO(mpcomplete): figure out proper time to call RemoveLazyListener.
103 if (extension && !extension->background_page_persists()) {
104 content::RenderThread::Get()->Send(
105 new ExtensionHostMsg_AddLazyListener(context->extension_id(),
106 event_name));
107 }
108 } 98 }
109 } 99 }
110 100
111 return v8::Undefined(); 101 return v8::Undefined();
112 } 102 }
113 103
114 static v8::Handle<v8::Value> DetachEvent(const v8::Arguments& args) { 104 static v8::Handle<v8::Value> DetachEvent(const v8::Arguments& args) {
115 DCHECK(args.Length() == 1); 105 DCHECK(args.Length() == 1);
116 // TODO(erikkay) should enforce that event name is a string in the bindings 106 // TODO(erikkay) should enforce that event name is a string in the bindings
117 DCHECK(args[0]->IsString() || args[0]->IsUndefined()); 107 DCHECK(args[0]->IsString() || args[0]->IsUndefined());
118 108
119 if (args[0]->IsString()) { 109 if (args[0]->IsString()) {
120 ExtensionImpl* v8_extension = GetFromArguments<ExtensionImpl>(args); 110 ExtensionImpl* v8_extension = GetFromArguments<ExtensionImpl>(args);
121 const ChromeV8ContextSet& context_set = 111 const ChromeV8ContextSet& context_set =
122 v8_extension->extension_dispatcher()->v8_context_set(); 112 v8_extension->extension_dispatcher()->v8_context_set();
123 ChromeV8Context* context = context_set.GetCurrent(); 113 ChromeV8Context* context = context_set.GetCurrent();
124 if (!context) 114 if (!context)
125 return v8::Undefined(); 115 return v8::Undefined();
126 116
127 EventListenerCounts& listener_counts = 117 EventListenerCounts& listener_counts =
128 GetListenerCounts(context->extension_id()); 118 GetListenerCounts(context->extension_id());
129 std::string event_name(*v8::String::AsciiValue(args[0])); 119 std::string event_name(*v8::String::AsciiValue(args[0]));
130
131 if (--listener_counts[event_name] == 0) { 120 if (--listener_counts[event_name] == 0) {
132 content::RenderThread::Get()->Send( 121 content::RenderThread::Get()->Send(
133 new ExtensionHostMsg_RemoveListener(context->extension_id(), 122 new ExtensionHostMsg_RemoveListener(context->extension_id(),
134 event_name)); 123 event_name));
135 } 124 }
136 } 125 }
137 126
138 return v8::Undefined(); 127 return v8::Undefined();
139 } 128 }
140 }; 129 };
141 130
142 } // namespace 131 } // namespace
143 132
144 v8::Extension* EventBindings::Get(ExtensionDispatcher* dispatcher) { 133 v8::Extension* EventBindings::Get(ExtensionDispatcher* dispatcher) {
145 static v8::Extension* extension = new ExtensionImpl(dispatcher); 134 static v8::Extension* extension = new ExtensionImpl(dispatcher);
146 return extension; 135 return extension;
147 } 136 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698