Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 9349015: [filebrowser] Save sorting field/order for modal dialogs, show spinner when scanning directories. (Closed)

Created:
8 years, 10 months ago by dgozman
Modified:
8 years, 10 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org
Visibility:
Public.

Description

[filebrowser] Save sorting field/order for modal dialogs, show spinner when scanning directories. BUG=chromium-os:23202 TEST=See bug. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120773

Patch Set 1 #

Patch Set 2 : Spinner itself #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -2 lines) Patch
M chrome/browser/resources/file_manager/css/file_manager.css View 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/browser/resources/file_manager/images/spinner.svg View 1 1 chunk +83 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/directory_model.js View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 6 chunks +32 lines, -1 line 0 comments Download
M chrome/browser/resources/file_manager/main.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dgozman
May you have a look, please?
8 years, 10 months ago (2012-02-07 13:49:34 UTC) #1
Vladislav Kaznacheev
8 years, 10 months ago (2012-02-07 13:57:38 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698