Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3675)

Unified Diff: chrome/browser/ui/webui/options2/browser_options_handler2.cc

Issue 9349003: [uber page] Improve a few titles for overall consistency. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options2/browser_options_handler2.cc
===================================================================
--- chrome/browser/ui/webui/options2/browser_options_handler2.cc (revision 120681)
+++ chrome/browser/ui/webui/options2/browser_options_handler2.cc (working copy)
@@ -117,7 +117,6 @@
{ "changeHomePage", IDS_OPTIONS_CHANGE_HOME_PAGE },
{ "customizeSync", IDS_OPTIONS2_CUSTOMIZE_SYNC_BUTTON_LABEL },
{ "defaultSearchManageEngines", IDS_OPTIONS_DEFAULTSEARCH_MANAGE_ENGINES },
- { "homePageTitle", IDS_OPTIONS2_HOMEPAGE_TITLE },
{ "homepageUseNewTab", IDS_OPTIONS_HOMEPAGE_USE_NEWTAB },
{ "homepageUseURL", IDS_OPTIONS_HOMEPAGE_USE_URL },
{ "instantConfirmMessage", IDS_INSTANT_OPT_IN_MESSAGE },
@@ -182,6 +181,8 @@
};
RegisterStrings(localized_strings, resources, arraysize(resources));
+ RegisterTitle(localized_strings, "homePageOverlay",
James Hawkins 2012/02/07 01:54:22 Wha? Why are we registering the title of the home
csilv 2012/02/07 01:58:34 HomePageOveray doesn't currently have a C++ handle
+ IDS_OPTIONS2_HOMEPAGE_TITLE);
localized_strings->SetString(
"syncOverview",
« no previous file with comments | « chrome/browser/resources/options2/startup_overlay.js ('k') | chrome/browser/ui/webui/options2/startup_pages_handler2.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698