Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: ppapi/proxy/ppp_class_proxy.cc

Issue 9348092: Revert 121901 - PPAPI: Add unlocking for PPP calls and callbacks. Add more locking. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/ppb_var_deprecated_proxy.cc ('k') | ppapi/proxy/ppp_graphics_3d_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/ppp_class_proxy.cc
===================================================================
--- ppapi/proxy/ppp_class_proxy.cc (revision 121902)
+++ ppapi/proxy/ppp_class_proxy.cc (working copy)
@@ -1,4 +1,4 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -8,7 +8,6 @@
#include "ppapi/c/dev/ppp_class_deprecated.h"
#include "ppapi/proxy/dispatcher.h"
#include "ppapi/proxy/ppapi_messages.h"
-#include "ppapi/shared_impl/proxy_lock.h"
#include "ppapi/proxy/serialized_var.h"
#include "ppapi/shared_impl/api_id.h"
@@ -244,28 +243,23 @@
SerializedVarReceiveInput property,
SerializedVarOutParam exception,
bool* result) {
- *result = CallWhileUnlocked(ToPPPClass(ppp_class)->HasProperty,
- ToUserData(object),
- property.Get(dispatcher()),
- exception.OutParam(dispatcher()));
+ *result = ToPPPClass(ppp_class)->HasProperty(ToUserData(object),
+ property.Get(dispatcher()), exception.OutParam(dispatcher()));
}
void PPP_Class_Proxy::OnMsgHasMethod(int64 ppp_class, int64 object,
SerializedVarReceiveInput property,
SerializedVarOutParam exception,
bool* result) {
- *result = CallWhileUnlocked(ToPPPClass(ppp_class)->HasMethod,
- ToUserData(object),
- property.Get(dispatcher()),
- exception.OutParam(dispatcher()));
+ *result = ToPPPClass(ppp_class)->HasMethod(ToUserData(object),
+ property.Get(dispatcher()), exception.OutParam(dispatcher()));
}
void PPP_Class_Proxy::OnMsgGetProperty(int64 ppp_class, int64 object,
SerializedVarReceiveInput property,
SerializedVarOutParam exception,
SerializedVarReturnValue result) {
- result.Return(dispatcher(), CallWhileUnlocked(
- ToPPPClass(ppp_class)->GetProperty,
+ result.Return(dispatcher(), ToPPPClass(ppp_class)->GetProperty(
ToUserData(object), property.Get(dispatcher()),
exception.OutParam(dispatcher())));
}
@@ -282,7 +276,7 @@
SerializedVarReceiveInput property,
SerializedVarReceiveInput value,
SerializedVarOutParam exception) {
- CallWhileUnlocked(ToPPPClass(ppp_class)->SetProperty,
+ ToPPPClass(ppp_class)->SetProperty(
ToUserData(object), property.Get(dispatcher()), value.Get(dispatcher()),
exception.OutParam(dispatcher()));
}
@@ -290,7 +284,7 @@
void PPP_Class_Proxy::OnMsgRemoveProperty(int64 ppp_class, int64 object,
SerializedVarReceiveInput property,
SerializedVarOutParam exception) {
- CallWhileUnlocked(ToPPPClass(ppp_class)->RemoveProperty,
+ ToPPPClass(ppp_class)->RemoveProperty(
ToUserData(object), property.Get(dispatcher()),
exception.OutParam(dispatcher()));
}
@@ -303,7 +297,7 @@
SerializedVarReturnValue result) {
uint32_t arg_count = 0;
PP_Var* args = arg_vector.Get(dispatcher(), &arg_count);
- result.Return(dispatcher(), CallWhileUnlocked(ToPPPClass(ppp_class)->Call,
+ result.Return(dispatcher(), ToPPPClass(ppp_class)->Call(
ToUserData(object), method_name.Get(dispatcher()),
arg_count, args, exception.OutParam(dispatcher())));
}
@@ -315,13 +309,12 @@
SerializedVarReturnValue result) {
uint32_t arg_count = 0;
PP_Var* args = arg_vector.Get(dispatcher(), &arg_count);
- result.Return(dispatcher(), CallWhileUnlocked(
- ToPPPClass(ppp_class)->Construct,
+ result.Return(dispatcher(), ToPPPClass(ppp_class)->Construct(
ToUserData(object), arg_count, args, exception.OutParam(dispatcher())));
}
void PPP_Class_Proxy::OnMsgDeallocate(int64 ppp_class, int64 object) {
- CallWhileUnlocked(ToPPPClass(ppp_class)->Deallocate, ToUserData(object));
+ ToPPPClass(ppp_class)->Deallocate(ToUserData(object));
}
} // namespace proxy
« no previous file with comments | « ppapi/proxy/ppb_var_deprecated_proxy.cc ('k') | ppapi/proxy/ppp_graphics_3d_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698