Issue 9348092: Revert 121901 - PPAPI: Add unlocking for PPP calls and callbacks. Add more locking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9348092: Revert 121901 - PPAPI: Add unlocking for PPP calls and callbacks. Add more locking. (Closed)

Created:
8 years, 10 months ago by dpapad

Modified:
8 years, 10 months ago

Reviewers:
dmichael (off chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 121901 - PPAPI: Add unlocking for PPP calls and callbacks. Add more locking. With this patch, ppapi_tests pass locally when building with enable_pepper_threading=1. (They didn't before). TODO: Test more calls off the main thread, make sync completion callbacks work. BUG=92909 TEST= Review URL: http://codereview.chromium.org/9391006 TBR=dmichael@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121903

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+71 lines, -235 lines)			Patch
M	ppapi/proxy/plugin_dispatcher.cc	View	4 chunks	+4 lines, -16 lines	0 comments	Download
M	ppapi/proxy/ppb_core_proxy.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	ppapi/proxy/ppb_flash_proxy.cc	View	8 chunks	+2 lines, -11 lines	0 comments	Download
M	ppapi/proxy/ppb_message_loop_proxy.cc	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	ppapi/proxy/ppb_testing_proxy.cc	View	6 chunks	+2 lines, -9 lines	0 comments	Download
M	ppapi/proxy/ppb_var_deprecated_proxy.cc	View	13 chunks	+4 lines, -15 lines	0 comments	Download
M	ppapi/proxy/ppp_class_proxy.cc	View	7 chunks	+11 lines, -18 lines	0 comments	Download
M	ppapi/proxy/ppp_graphics_3d_proxy.cc	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	ppapi/proxy/ppp_input_event_proxy.cc	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	ppapi/proxy/ppp_instance_private_proxy.cc	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	ppapi/proxy/ppp_instance_private_proxy_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppp_messaging_proxy.cc	View	3 chunks	+2 lines, -5 lines	0 comments	Download
M	ppapi/proxy/ppp_mouse_lock_proxy.cc	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	ppapi/proxy/ppp_video_decoder_proxy.cc	View	1 chunk	+8 lines, -17 lines	0 comments	Download
M	ppapi/proxy/serialized_var_unittest.cc	View	8 chunks	+0 lines, -8 lines	0 comments	Download
M	ppapi/shared_impl/ppp_instance_combined.cc	View	2 chunks	+9 lines, -15 lines	0 comments	Download
M	ppapi/shared_impl/proxy_lock.h	View	3 chunks	+0 lines, -75 lines	0 comments	Download
M	ppapi/shared_impl/proxy_lock.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	ppapi/shared_impl/tracked_callback.cc	View	4 chunks	+4 lines, -5 lines	0 comments	Download
M	ppapi/thunk/enter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/thunk/enter.cc	View	5 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages