Issue 9348058: Simplify stackframe of construct stub on ARM and MIPS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9348058: Simplify stackframe of construct stub on ARM and MIPS. (Closed)

Created:
8 years, 10 months ago by Michael Starzinger

Modified:
8 years, 10 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Simplify stackframe of construct stub on ARM and MIPS. This unifies the stackframe layout of the generic constructor stub to be in sync with ia32 and x64. There was an unecessary copy of the construct function saved on the stack which wasn't used at all. R=erik.corry@gmail.com Committed: https://code.google.com/p/v8/source/detail?r=10653

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -52 lines)			Patch
	M	src/arm/builtins-arm.cc	View		3 chunks	+11 lines, -27 lines	0 comments	Download
	M	src/mips/builtins-mips.cc	View		3 chunks	+9 lines, -25 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages