Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 9348051: Fix d8-os unit test to work with isolates. (Closed)

Created:
8 years, 10 months ago by Michael Starzinger
Modified:
8 years, 10 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Fix d8-os unit test to work with isolates. We cannot use chdir to set the working directory on a per-isolate basis, hence we need to specify absolute directories instead for this test to work properly on multi-threaded runs. R=yangguo@chromium.org TEST=mjsunit/d8-os Committed: https://code.google.com/p/v8/source/detail?r=10639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -27 lines) Patch
M test/mjsunit/d8-os.js View 1 chunk +26 lines, -27 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
8 years, 10 months ago (2012-02-08 10:56:59 UTC) #1
Yang
8 years, 10 months ago (2012-02-08 10:58:10 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698