Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1618)

Unified Diff: runtime/vm/snapshot.h

Issue 9348048: Add support for medium integers to the native message format (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments from asiva@ Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_message.cc ('k') | runtime/vm/snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/snapshot.h
diff --git a/runtime/vm/snapshot.h b/runtime/vm/snapshot.h
index a9464d67ae84585777d2862b1f6543394ecf3a60..d8b44ac4fb1ca2d2733d4a076ae2e10927acf8ac 100644
--- a/runtime/vm/snapshot.h
+++ b/runtime/vm/snapshot.h
@@ -471,7 +471,7 @@ class MessageWriter : public BaseWriter {
public:
MessageWriter(uint8_t** buffer, ReAlloc alloc)
: BaseWriter(buffer, alloc), object_id_(0) {
- ASSERT(kDartCObjectTypeMask >= Dart_CObject::kNumberOfTypes);
+ ASSERT(kDartCObjectTypeMask >= Dart_CObject::kNumberOfTypes - 1);
}
~MessageWriter() { }
@@ -496,7 +496,10 @@ class MessageWriter : public BaseWriter {
intptr_t GetMarkedCObjectMark(Dart_CObject* object);
void UnmarkAllCObjects(Dart_CObject* object);
- void WriteSmi(int32_t value);
+ void WriteSmi(int64_t value);
+ void WriteMint(Dart_CObject* object, int64_t value);
+ void WriteInt32(Dart_CObject* object);
+ void WriteInt64(Dart_CObject* object);
void WriteInlinedHeader(Dart_CObject* object);
void WriteCObject(Dart_CObject* object);
« no previous file with comments | « runtime/vm/dart_api_message.cc ('k') | runtime/vm/snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698