Issue 9348048: Add support for medium integers to the native message format

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9348048: Add support for medium integers to the native message format (Closed)

Created:
8 years, 10 months ago by Søren Gjesse

Modified:
8 years, 10 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add support for medium integers to the native message format R=asiva@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4073

Patch Set 2 : Addressed review comments from asiva@ #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+137 lines, -6 lines)			Patch
M	runtime/include/dart_api.h	View	1	3 chunks	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_message.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_message.cc	View	1	2 chunks	+16 lines, -0 lines	0 comments	Download
M	runtime/vm/snapshot.h	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/snapshot.cc	View	1	2 chunks	+38 lines, -4 lines	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	1	2 chunks	+73 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

LGTM https://chromiumcodereview.appspot.com/9348048/diff/1/runtime/vm/snapshot.cc File runtime/vm/snapshot.cc (right): https://chromiumcodereview.appspot.com/9348048/diff/1/runtime/vm/snapshot.cc#newcode558 runtime/vm/snapshot.cc:558: case Dart_CObject::kInt32: Why not leave this as WriteSmi(..) ...

8 years, 10 months ago (2012-02-09 01:07:21 UTC) #2

Søren Gjesse

8 years, 10 months ago (2012-02-09 10:29:06 UTC) #3

https://chromiumcodereview.appspot.com/9348048/diff/1/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://chromiumcodereview.appspot.com/9348048/diff/1/runtime/vm/snapshot.cc#...
runtime/vm/snapshot.cc:558: case Dart_CObject::kInt32:
On 2012/02/09 01:07:21, asiva wrote:
> Why not leave this as WriteSmi(..) here and instead of WriteInteger(...) have
a
> WriteInt64(...) method. That way
> you don't have to do these multiple checks.
> 
> The WriteInt64 guy can do a check to see if the value fits in a Smi and
WriteSmi
> of an int32_t quantity.

Added WriteInt32, WriteInt64 and WriteMint together with WriteSmi and avided
double checking.

Expand Messages | Collapse Messages

Issue 9348048: Add support for medium integers to the native message format (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed review comments from asiva@ #

Messages