Issue 9348024: Infobar the NVIDIA 3D vision plug-ins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9348024: Infobar the NVIDIA 3D vision plug-ins. (Closed)

Created:
8 years, 10 months ago by Chris Evans

Modified:
8 years, 10 months ago

Reviewers:
Bernhard Bauer, cevans

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Infobar the NVIDIA 3D vision plug-ins. BUG=113047 TBR=bauerb Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120832

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	webkit/plugins/npapi/plugin_list.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Chris Evans

These appeared by apparent stealth at some time on my machine.

8 years, 10 months ago (2012-02-07 19:32:13 UTC) #1

Bernhard Bauer

LGTM. Would it make sense to think about infobaring unknown plug-ins in general? If we're ...

8 years, 10 months ago (2012-02-07 20:46:01 UTC) #2

cevans

8 years, 10 months ago (2012-02-07 20:50:25 UTC) #3

On Tue, Feb 7, 2012 at 12:46 PM, <bauerb@chromium.org> wrote:

> LGTM.
>
> Would it make sense to think about infobaring unknown plug-ins in general?
> If
> we're whitelisting (some of) the most commonly used plug-ins anyway, the
> impact
> shouldn't be big, and we wouldn't need to add this even more plug-ins.
>

Interesting idea. You want to tackle it or should I add it to my TODO?


>
>
https://chromiumcodereview.**appspot.com/9348024/<https://chromiumcodereview....
>

Expand Messages | Collapse Messages