Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: tools/testing/dart/test_options.dart

Issue 9348015: Make test.dart exit with an error message when a selector is repeated. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_options.dart
diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart
index e5ac329ce2c3e45c3a590825b551d24ec6d6dd88..954aae4f432d1b88916de8b606332de38348a8c8 100644
--- a/tools/testing/dart/test_options.dart
+++ b/tools/testing/dart/test_options.dart
@@ -373,8 +373,9 @@ is 'dart file.dart' and you specify special command
pattern = ".*";
}
if (selectorMap.containsKey(suite)) {
- print("Warning: selector '$suite/$pattern' overrides " +
- "previous selector for suite '$suite'");
+ print("Error: '$suite/$pattern'. Only one test selection" +
+ " pattern is allowed to start with '$suite/'");
+ exit(1);
}
selectorMap[suite] = new RegExp(pattern);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698