Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 9348012: Help: Fix a crash because of using only a $2 paramter in a string. (Closed)

Created:
8 years, 10 months ago by James Hawkins
Modified:
8 years, 10 months ago
Reviewers:
csilv
CC:
chromium-reviews
Visibility:
Public.

Description

Help: Fix a crash because of using only a $2 paramter in a string. The strings system doesn't work the way I thought it should. BUG=112953 TEST=none R=csilv Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/help/help_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
James Hawkins
8 years, 10 months ago (2012-02-07 09:21:26 UTC) #1
csilv
8 years, 10 months ago (2012-02-07 19:07:43 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698