Issue 9348006: Revert unnecessary change I checked in by mistake.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9348006: Revert unnecessary change I checked in by mistake. (Closed)

Created:
8 years, 10 months ago by oshima

Modified:
8 years, 10 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert unnecessary change I checked in by mistake in r120670 TBR=ben@chromium.org BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120696

Patch Set 1 : revert change made by mistake #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ui/views/widget/native_widget_aura_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

8 years, 10 months ago (2012-02-07 03:45:58 UTC) #2

LGTM

On Mon, Feb 6, 2012 at 6:54 PM, <oshima@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Revert unnecessary change I checked in by mistake in r120670
>
> TBR=ben@chromium.org
> BUG=none
> TEST=none
>
> Committed: https://src.chromium.org/**viewvc/chrome?view=rev&**
>
revision=120696<https://src.chromium.org/viewvc/chrome?view=rev&revision=120696>
>
> Please review this at
https://chromiumcodereview.**appspot.com/9348006/<https://chromiumcodereview....
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M ui/views/widget/native_widget_**aura_unittest.cc
>
>
> Index: ui/views/widget/native_widget_**aura_unittest.cc
> diff --git a/ui/views/widget/native_**widget_aura_unittest.cc
> b/ui/views/widget/native_**widget_aura_unittest.cc
> index e7ddf312e729820d2c7cc2425f9145**9539e14d4e..**
> 2b9f874091b51d9ebe6ac5db8e8390**0e83a3ec42 100644
> --- a/ui/views/widget/native_**widget_aura_unittest.cc
> +++ b/ui/views/widget/native_**widget_aura_unittest.cc
> @@ -153,7 +153,7 @@ TEST_F(NativeWidgetAuraTest,
> GetClientAreaScreenBounds) {
>   Widget::InitParams params(Widget::InitParams::**TYPE_WINDOW);
>   params.ownership = views::Widget::InitParams::**
> WIDGET_OWNS_NATIVE_WIDGET;
>   params.bounds.SetRect(10, 20, 300, 400);
> -  Widget* widget = new Widget();
> +  scoped_ptr<Widget> widget(new Widget());
>   widget->Init(params);
>
>   // For Aura, client area bounds match window bounds.
>
>
>

Expand Messages | Collapse Messages