Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: icu.gyp

Issue 9347044: Add -Wno-switch to ICU. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/icu46/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'use_system_icu%': 0, 7 'use_system_icu%': 0,
8 'icu_use_data_file_flag%': 0, 8 'icu_use_data_file_flag%': 0,
9 }, 9 },
10 'target_defaults': { 10 'target_defaults': {
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 # ICU uses its own deprecated functions. 326 # ICU uses its own deprecated functions.
327 '-Wno-deprecated-declarations', 327 '-Wno-deprecated-declarations',
328 # ICU prefers `a && b || c` over `(a && b) || c`. 328 # ICU prefers `a && b || c` over `(a && b) || c`.
329 '-Wno-logical-op-parentheses', 329 '-Wno-logical-op-parentheses',
330 # ICU has some `unsigned < 0` checks. 330 # ICU has some `unsigned < 0` checks.
331 '-Wno-tautological-compare', 331 '-Wno-tautological-compare',
332 # uspoof.h has a U_NAMESPACE_USE macro. That's a bug, 332 # uspoof.h has a U_NAMESPACE_USE macro. That's a bug,
333 # the header should use U_NAMESPACE_BEGIN instead. 333 # the header should use U_NAMESPACE_BEGIN instead.
334 # http://bugs.icu-project.org/trac/ticket/9054 334 # http://bugs.icu-project.org/trac/ticket/9054
335 '-Wno-header-hygiene', 335 '-Wno-header-hygiene',
336 # uresdata.c has switch(RES_GET_TYPE(x)) code. The
337 # RES_GET_TYPE macro returns an UResType enum, but some switch
338 # statement contains case values that aren't part of that
339 # enum (e.g. URES_TABLE32 which is in UResInternalType). This
340 # is on purpose.
341 '-Wno-switch',
336 ], 342 ],
337 }, 343 },
338 'cflags': [ 344 'cflags': [
339 '-Wno-deprecated-declarations', 345 '-Wno-deprecated-declarations',
340 '-Wno-logical-op-parentheses', 346 '-Wno-logical-op-parentheses',
341 '-Wno-tautological-compare', 347 '-Wno-tautological-compare',
342 '-Wno-header-hygiene', 348 '-Wno-header-hygiene',
349 '-Wno-switch',
343 ], 350 ],
344 }], 351 }],
345 ], 352 ],
346 }, 353 },
347 { 354 {
348 'target_name': 'icuuc', 355 'target_name': 'icuuc',
349 'type': '<(component)', 356 'type': '<(component)',
350 'sources': [ 357 'sources': [
351 'source/common/bmpset.cpp', 358 'source/common/bmpset.cpp',
352 'source/common/brkeng.cpp', 359 'source/common/brkeng.cpp',
(...skipping 284 matching lines...) Expand 10 before | Expand all | Expand 10 after
637 { 644 {
638 'target_name': 'icuuc', 645 'target_name': 'icuuc',
639 'type': 'none', 646 'type': 'none',
640 'dependencies': ['system_icu'], 647 'dependencies': ['system_icu'],
641 'export_dependent_settings': ['system_icu'], 648 'export_dependent_settings': ['system_icu'],
642 }, 649 },
643 ], 650 ],
644 }], 651 }],
645 ], 652 ],
646 } 653 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698