Introduce content::RenderWidgetHostViewPort (in content/port/browser).

Introduce content::RenderWidgetHostViewPort (in content/port/browser).

Move RenderWidgetHostViewBase and TestRenderWidgetHostView to content
namespace.

Follow-up changes will move RenderWidgetHostView to content namespace,
and get rid of content/browser/renderer_host/render_widget_host_view.h
which is now just a redirect header.

BUG=98716
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122288

[jam, 2012-02-15 17:02:18]

lgtm

http://codereview.chromium.org/9347042/diff/1/content/browser/renderer_host/r...
File content/browser/renderer_host/render_widget_host_view_base.h (right):

http://codereview.chromium.org/9347042/diff/1/content/browser/renderer_host/r...
content/browser/renderer_host/render_widget_host_view_base.h:1: // Copyright (c)
2012 The Chromium Authors. All rights reserved.
can you svn copy this, or the equivalent under git, so that diffs work?

http://codereview.chromium.org/9347042/diff/1/content/browser/renderer_host/r...
content/browser/renderer_host/render_widget_host_view_base.h:49: virtual void
SetShowingContextMenu(bool) OVERRIDE;
nit: didn't see this before, we should have a parameter name here

http://codereview.chromium.org/9347042/diff/1/content/port/browser/render_wid...
File content/port/browser/render_widget_host_view_port.cc (right):

http://codereview.chromium.org/9347042/diff/1/content/port/browser/render_wid...
content/port/browser/render_widget_host_view_port.cc:22:
RenderWidgetHostViewPort* RenderWidgetHostViewPort::CreateViewForWidget(
nit: can we put these two static methods somewhere in content/browser
(render_widget_host_view_base.cc?) and avoid this cc file altogether?

http://codereview.chromium.org/9347042/diff/1/content/port/browser/render_wid...
File content/port/browser/render_widget_host_view_port.h (right):

http://codereview.chromium.org/9347042/diff/1/content/port/browser/render_wid...
content/port/browser/render_widget_host_view_port.h:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
nit: please add an OWNERS file for the port directory. it can probably start the
same as the top level content\public one.

http://codereview.chromium.org/9347042/diff/1/content/port/browser/render_wid...
content/port/browser/render_widget_host_view_port.h:249:
DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewPort);
nit: this isn't needed since an interface isn't copyable

http://codereview.chromium.org/9347042/diff/1/content/public/browser/render_w...
File content/public/browser/render_widget_host_view.cc (right):

http://codereview.chromium.org/9347042/diff/1/content/public/browser/render_w...
content/public/browser/render_widget_host_view.cc:7:
RenderWidgetHostView::RenderWidgetHostView() {
nit: not needed

http://codereview.chromium.org/9347042/diff/1/content/public/browser/render_w...
content/public/browser/render_widget_host_view.cc:10:
RenderWidgetHostView::~RenderWidgetHostView() {
nit: just put this in the .h and then we can avoid this cc file altogether

http://codereview.chromium.org/9347042/diff/1/content/public/browser/render_w...
File content/public/browser/render_widget_host_view.h (right):

http://codereview.chromium.org/9347042/diff/1/content/public/browser/render_w...
content/public/browser/render_widget_host_view.h:142:
DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostView);
ditto

[Jói, 2012-02-16 12:41:42]

Addressed all comments, submitting now via CQ.

http://codereview.chromium.org/9347042/diff/1/content/browser/renderer_host/r...
File content/browser/renderer_host/render_widget_host_view_base.h (right):

http://codereview.chromium.org/9347042/diff/1/content/browser/renderer_host/r...
content/browser/renderer_host/render_widget_host_view_base.h:1: // Copyright (c)
2012 The Chromium Authors. All rights reserved.
On 2012/02/15 17:02:19, John Abd-El-Malek wrote:
> can you svn copy this, or the equivalent under git, so that diffs work?

As discussed off-line, this is hard because of the git -> git svn limitations.

http://codereview.chromium.org/9347042/diff/1/content/browser/renderer_host/r...
content/browser/renderer_host/render_widget_host_view_base.h:49: virtual void
SetShowingContextMenu(bool) OVERRIDE;
On 2012/02/15 17:02:19, John Abd-El-Malek wrote:
> nit: didn't see this before, we should have a parameter name here

Done.

http://codereview.chromium.org/9347042/diff/1/content/port/browser/render_wid...
File content/port/browser/render_widget_host_view_port.cc (right):

http://codereview.chromium.org/9347042/diff/1/content/port/browser/render_wid...
content/port/browser/render_widget_host_view_port.cc:22:
RenderWidgetHostViewPort* RenderWidgetHostViewPort::CreateViewForWidget(
On 2012/02/15 17:02:19, John Abd-El-Malek wrote:
> nit: can we put these two static methods somewhere in content/browser
> (render_widget_host_view_base.cc?) and avoid this cc file altogether?

Done.

http://codereview.chromium.org/9347042/diff/1/content/port/browser/render_wid...
File content/port/browser/render_widget_host_view_port.h (right):

http://codereview.chromium.org/9347042/diff/1/content/port/browser/render_wid...
content/port/browser/render_widget_host_view_port.h:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2012/02/15 17:02:19, John Abd-El-Malek wrote:
> nit: please add an OWNERS file for the port directory. it can probably start
the
> same as the top level content\public one.

Done.

http://codereview.chromium.org/9347042/diff/1/content/port/browser/render_wid...
content/port/browser/render_widget_host_view_port.h:249:
DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewPort);
On 2012/02/15 17:02:19, John Abd-El-Malek wrote:
> nit: this isn't needed since an interface isn't copyable

Done.

http://codereview.chromium.org/9347042/diff/1/content/public/browser/render_w...
File content/public/browser/render_widget_host_view.cc (right):

http://codereview.chromium.org/9347042/diff/1/content/public/browser/render_w...
content/public/browser/render_widget_host_view.cc:7:
RenderWidgetHostView::RenderWidgetHostView() {
On 2012/02/15 17:02:19, John Abd-El-Malek wrote:
> nit: not needed

Done.

http://codereview.chromium.org/9347042/diff/1/content/public/browser/render_w...
content/public/browser/render_widget_host_view.cc:10:
RenderWidgetHostView::~RenderWidgetHostView() {
On 2012/02/15 17:02:19, John Abd-El-Malek wrote:
> nit: just put this in the .h and then we can avoid this cc file altogether

Done.

http://codereview.chromium.org/9347042/diff/1/content/public/browser/render_w...
File content/public/browser/render_widget_host_view.h (right):

http://codereview.chromium.org/9347042/diff/1/content/public/browser/render_w...
content/public/browser/render_widget_host_view.h:142:
DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostView);
On 2012/02/15 17:02:19, John Abd-El-Malek wrote:
> ditto

Done.

[commit-bot: I haz the power, 2012-02-16 14:01:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/9347042/6038

[commit-bot: I haz the power, 2012-02-16 14:47:05]

Try job failure for 9347042-6038 (retry) on linux_rel for step "check_deps".
It's a second try, previously, step "check_deps" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...