Issue 9347031: Merge 120807 - Revert 116685 - Make incognito windows not inherit HSTS state from the main profile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9347031: Merge 120807 - Revert 116685 - Make incognito windows not inherit HSTS state from the main profile. (Closed)

Created:
8 years, 10 months ago by palmer

Modified:
8 years, 10 months ago

Reviewers:
palmer

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/branches/1025/src/

Visibility:
Public.

Merge 120807 - Revert 116685 - Make incognito windows not inherit HSTS state from the main profile. The dynamic HSTS state is loaded by the TransportSecurityPersister. By moving it up into profile_impl (which isn't shared by Incognito profiles), the Incognito profiles don't ever load dynamic state. BUG=104935 TEST=Inject an HSTS entry for a non-HTTPS site in the main profile using about:net-internals. Open an incognito window and verify that you can still access the HTTP site. Review URL: http://codereview.chromium.org/8997012 TBR=agl@chromium.org,cevans@google.com Review URL: https://chromiumcodereview.appspot.com/9349029 TBR=palmer@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120816

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -13 lines)			Patch
M	chrome/browser/profiles/profile_impl_io_data.h	View	3 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/browser/profiles/profile_impl_io_data.cc	View	3 chunks	+1 line, -7 lines	0 comments	Download
M	chrome/browser/profiles/profile_io_data.h	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/profiles/profile_io_data.cc	View	3 chunks	+6 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)