Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Unified Diff: media/filters/audio_renderer_base.cc

Issue 9347029: Decouple 'give me more data' and 'rendered end of stream' audio callbacks. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/audio_renderer_base.cc
===================================================================
--- media/filters/audio_renderer_base.cc (revision 121128)
+++ media/filters/audio_renderer_base.cc (working copy)
@@ -272,8 +272,10 @@
}
void AudioRendererBase::SignalEndOfStream() {
- DCHECK(recieved_end_of_stream_);
- if (!rendered_end_of_stream_) {
+ // Lock, there is potential race condition on
+ // |recieved_end_of_stream_| and |rendered_end_of_stream_|.
+ base::AutoLock auto_lock(lock_);
+ if (recieved_end_of_stream_ && !rendered_end_of_stream_) {
rendered_end_of_stream_ = true;
host()->NotifyEnded();
}
« content/renderer/media/audio_renderer_impl.h ('K') | « media/filters/audio_renderer_base.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698