Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Issue 9347015: Revert 120417 - roll clang 148911:149419 (Closed)

Created:
8 years, 10 months ago by satorux1
Modified:
8 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews, fischman+watch_chromium.org, pam+watch_chromium.org, ukai+watch_chromium.org
Visibility:
Public.

Description

Revert 120417 - roll clang 148911:149419 This pulled a bad revision of clang, that made mac_rel try bots sick. BUG=112977 TEST=cross fingers. Should fix -Wformat issues on 10.6. test/Index/crash-recovery-modules.m fails locally at this revision, but we don't use the modules stuff yet anyway, so I disabled that test locally for this roll. BUG=111861 TEST=none TBR=hans Review URL: http://codereview.chromium.org/9316097 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/clang/scripts/update.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
satorux1
8 years, 10 months ago (2012-02-07 06:58:40 UTC) #1
Nico
8 years, 10 months ago (2012-02-07 07:02:49 UTC) #2
Lgtm
On Feb 6, 2012 10:58 PM, <satorux@chromium.org> wrote:

> Reviewers: Nico,
>
> Description:
> Revert 120417 - roll clang 148911:149419
>
> This pulled a bad revision of clang, that made mac_rel try bots sick.
> BUG=112977
> TEST=cross fingers.
>
> Should fix -Wformat issues on 10.6.
>
> test/Index/crash-recovery-**modules.m fails locally at this revision, but
> we don't
> use the modules stuff yet anyway, so I disabled that test locally for this
> roll.
>
> BUG=111861
> TEST=none
> TBR=hans
>
> Review URL:
http://codereview.chromium.**org/9316097<http://codereview.chromium.org/9316097>
>
> TBR=thakis@chromium.org
>
> Please review this at
https://chromiumcodereview.**appspot.com/9347015/<https://chromiumcodereview....
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     tools/clang/scripts/update.sh
>
>
> Index: tools/clang/scripts/update.sh
> ==============================**==============================**=======
> --- tools/clang/scripts/update.sh       (revision 120731)
> +++ tools/clang/scripts/update.sh       (working copy)
> @@ -8,7 +8,7 @@
>  # Do NOT CHANGE this if you don't know what you're doing -- see
>  #
https://code.google.com/p/**chromium/wiki/UpdatingClang<https://code.google.c...
>  # Reverting problematic clang rolls is safe, though.
> -CLANG_REVISION=149419
> +CLANG_REVISION=148911
>
>  THIS_DIR="$(dirname "${0}")"
>  LLVM_DIR="${THIS_DIR}/../../..**/third_party/llvm"
>
>
>

Powered by Google App Engine
This is Rietveld 408576698