Issue 9347013: Adds '#'s to the beginning of each output line when running with -d

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9347013: Adds '#'s to the beginning of each output line when running with -d (Closed)

Created:
8 years, 10 months ago by Tyler Breisacher (Chromium)

Modified:
8 years, 10 months ago

Reviewers:
Nico

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Adds '#'s to the beginning of each output line when running with -d This way, if the output format changes in a way that confuses the bot running sizes.py, we can tell the bot to just ignore lines that start with '#'. See http://codereview.chromium.org/9323047/#msg11 BUG=102013 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120726

Patch Set 1 #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	tools/linux/dump-static-initializers.py	View		2 chunks	+8 lines, -4 lines	1 comment	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Nico

8 years, 10 months ago (2012-02-07 05:53:19 UTC) #1

lgtm

https://chromiumcodereview.appspot.com/9347013/diff/1/tools/linux/dump-static...
File tools/linux/dump-static-initializers.py (right):

https://chromiumcodereview.appspot.com/9347013/diff/1/tools/linux/dump-static...
tools/linux/dump-static-initializers.py:191: 
Just

  if opts.diffable:
    print '#',
  print 'Found %d...'

is a bit simpler

Expand Messages | Collapse Messages