Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 9347006: Disable tests that don't run on ChromeOS (Closed)

Created:
8 years, 10 months ago by krisr
Modified:
8 years, 10 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews
Visibility:
Public.

Description

Disable tests that don't run on ChromeOS Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120689

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/test/functional/PYAUTO_TESTS View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
krisr
8 years, 10 months ago (2012-02-07 01:28:57 UTC) #1
Nirnimesh
https://chromiumcodereview.appspot.com/9347006/diff/1/chrome/test/functional/PYAUTO_TESTS File chrome/test/functional/PYAUTO_TESTS (right): https://chromiumcodereview.appspot.com/9347006/diff/1/chrome/test/functional/PYAUTO_TESTS#newcode295 chrome/test/functional/PYAUTO_TESTS:295: '-prefs.PrefsTest.testGeolocationBlockedWhenTrackingDenied' what's wrong with this?
8 years, 10 months ago (2012-02-07 01:31:22 UTC) #2
Nirnimesh
http://codereview.chromium.org/9347006/diff/1/chrome/test/functional/PYAUTO_TESTS File chrome/test/functional/PYAUTO_TESTS (right): http://codereview.chromium.org/9347006/diff/1/chrome/test/functional/PYAUTO_TESTS#newcode295 chrome/test/functional/PYAUTO_TESTS:295: '-prefs.PrefsTest.testGeolocationBlockedWhenTrackingDenied' Someone recently updated this test to use webdriver, ...
8 years, 10 months ago (2012-02-07 01:49:04 UTC) #3
krisr
PTAL On Mon, Feb 6, 2012 at 5:49 PM, <nirnimesh@chromium.org> wrote: > > http://codereview.chromium.**org/9347006/diff/1/chrome/** > ...
8 years, 10 months ago (2012-02-07 01:52:07 UTC) #4
Nirnimesh
8 years, 10 months ago (2012-02-07 02:02:58 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698