Set OmitFramePointers to false for official builds to do some tests.

Set OmitFramePointers to false for official builds to do some tests. 

BUG=NONE 
TBR=eroman@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120793

[eroman, 2012-02-07 17:15:27]

lgtm

On Tue, Feb 7, 2012 at 8:49 AM, <kerz@chromium.org> wrote:

> Reviewers: eroman,
>
> Description:
> Set OmitFramePointers to false for official builds to do some tests.
>
> BUG=NONE
> TBR=eroman@chromium.org
>
> Please review this at
https://chromiumcodereview.**appspot.com/9346022/<https://chromiumcodereview....
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     build/internal/release_impl_**official.gypi
>
>
> Index: build/internal/release_impl_**official.gypi
> ==============================**==============================**=======
> --- build/internal/release_impl_**official.gypi   (revision 120785)
> +++ build/internal/release_impl_**official.gypi   (working copy)
> @@ -8,7 +8,7 @@
>     'VCCLCompilerTool': {
>       'InlineFunctionExpansion': '2',
>       'EnableIntrinsicFunctions': 'true',
> -      'OmitFramePointers': 'true',
> +      'OmitFramePointers': 'false',
>       'EnableFiberSafeOptimizations'**: 'true',
>     },
>     'VCLibrarianTool': {
>
>
>

[eroman, 2012-02-08 21:56:52]

Actually I don't think that is sufficient.
The following comment from win_release_OmitFramePointers says that one must also
specify /Oy- to really disable FPO.

['win_release_OmitFramePointers==0', {
    'OmitFramePointers': 'false',
    # The above is not sufficient (http://crbug.com/106711): it
    # simply eliminates an explicit "/Oy", but both /O2 and /Ox
    # perform FPO regardless, so we must explicitly disable.
    # We still want the false setting above to avoid having
    # "/Oy /Oy-" and warnings about overriding.
    'AdditionalOptions': ['/Oy-'],
}],