runtime/bin/file_linux.cc - Issue 9346015: Change file opening operation to set position at the end of the file when FileMode.APPEND is used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/file_linux.cc

Issue 9346015: Change file opening operation to set position at the end of the file when FileMode.APPEND is used. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: '' Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/file_linux.cc

===================================================================

--- runtime/bin/file_linux.cc (revision 3943)

+++ runtime/bin/file_linux.cc (working copy)

@@ -116,6 +116,10 @@

if (fd < 0) {

return NULL;

}

+ if (((mode & kWrite) != 0) && ((mode & kTruncate) == 0)) {

+ int position = TEMP_FAILURE_RETRY(lseek(fd, 0, SEEK_END));

+ ASSERT(position >= 0);

Mads Ager (google) 2012/02/07 09:23:27 return NULL instead?

+ }

return new File(name, new FileHandle(fd));

}

« no previous file with comments | « runtime/bin/file_impl.dart ('k') | runtime/bin/file_macos.cc » ('j') | no next file with comments »